[dpdk-test-report] |WARNING| pw79655 [PATCH v2 36/56] net/txgbe: add VLAN handle support

[dpdk-test-report] |WARNING| pw79655 [PATCH v2 36/56] net/txgbe: add VLAN handle support

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79655

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#212: FILE: drivers/net/txgbe/txgbe_ethdev.c:45:
+#define TXGBE_SET_HWSTRIP(h, q) do {\
+		uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \
+		uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \
+		(h)->bitmap[idx] |= 1 << bit;\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#218: FILE: drivers/net/txgbe/txgbe_ethdev.c:51:
+#define TXGBE_CLEAR_HWSTRIP(h, q) do {\
+		uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \
+		uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \
+		(h)->bitmap[idx] &= ~(1 << bit);\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#224: FILE: drivers/net/txgbe/txgbe_ethdev.c:57:
+#define TXGBE_GET_HWSTRIP(h, q, r) do {\
+		uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \
+		uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \
+		(r) = (h)->bitmap[idx] >> bit & 1;\
+	} while (0)

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#522: FILE: drivers/net/txgbe/txgbe_ethdev.c:844:
+		if (rxq->offloads & DEV_RX_OFFLOAD_VLAN_STRIP) {
[...]
+		} else {
[...]

WARNING:BRACES: braces {} are not necessary for single statement blocks
#558: FILE: drivers/net/txgbe/txgbe_ethdev.c:880:
+	if (mask & ETH_VLAN_STRIP_MASK) {
+		txgbe_vlan_hw_strip_config(dev);
+	}

total: 0 errors, 2 warnings, 3 checks, 572 lines checked