From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C8453A04BB
	for <public@inbox.dpdk.org>; Tue,  6 Oct 2020 11:43:38 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 418D71B222;
	Tue,  6 Oct 2020 11:43:36 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id E92221C01; Tue,  6 Oct 2020 11:43:33 +0200 (CEST)
In-Reply-To: <20201005120910.189343-37-jiawenwu@trustnetic.com>
References: <20201005120910.189343-37-jiawenwu@trustnetic.com>
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Message-Id: <20201006094333.E92221C01@dpdk.org>
Date: Tue,  6 Oct 2020 11:43:33 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw79655 [PATCH v2 36/56] net/txgbe:
	add VLAN handle support
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79655

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#212: FILE: drivers/net/txgbe/txgbe_ethdev.c:45:
+#define TXGBE_SET_HWSTRIP(h, q) do {\
+		uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \
+		uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \
+		(h)->bitmap[idx] |= 1 << bit;\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#218: FILE: drivers/net/txgbe/txgbe_ethdev.c:51:
+#define TXGBE_CLEAR_HWSTRIP(h, q) do {\
+		uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \
+		uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \
+		(h)->bitmap[idx] &= ~(1 << bit);\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#224: FILE: drivers/net/txgbe/txgbe_ethdev.c:57:
+#define TXGBE_GET_HWSTRIP(h, q, r) do {\
+		uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \
+		uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \
+		(r) = (h)->bitmap[idx] >> bit & 1;\
+	} while (0)

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#522: FILE: drivers/net/txgbe/txgbe_ethdev.c:844:
+		if (rxq->offloads & DEV_RX_OFFLOAD_VLAN_STRIP) {
[...]
+		} else {
[...]

WARNING:BRACES: braces {} are not necessary for single statement blocks
#558: FILE: drivers/net/txgbe/txgbe_ethdev.c:880:
+	if (mask & ETH_VLAN_STRIP_MASK) {
+		txgbe_vlan_hw_strip_config(dev);
+	}

total: 0 errors, 2 warnings, 3 checks, 572 lines checked