[dpdk-test-report] |WARNING| pw79657 [PATCH v2 39/56] net/txgbe: add process mailbox operation

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw79657 [PATCH v2 39/56] net/txgbe: add process mailbox operation
Date: Tue,  6 Oct 2020 11:43:43 +0200 (CEST)	[thread overview]
Message-ID: <20201006094343.CD4352952@dpdk.org> (raw)
In-Reply-To: <20201005120910.189343-40-jiawenwu@trustnetic.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79657

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#60: 
Add check operation for vf function level reset, mailbox messages and ack from vf. Waiting to process the messages.

CHECK:BRACES: braces {} should be used on all arms of this statement
#143: FILE: drivers/net/txgbe/base/txgbe_mbx.c:51:
+	if (size > mbx->size) {
[...]
+	} else if (mbx->write)
[...]

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#365: FILE: drivers/net/txgbe/base/txgbe_mbx.c:273:
+
+}

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#422: FILE: drivers/net/txgbe/base/txgbe_mbx.h:17:
+					    * this are the ACK */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#424: FILE: drivers/net/txgbe/base/txgbe_mbx.h:19:
+					    * this are the NACK */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#426: FILE: drivers/net/txgbe/base/txgbe_mbx.h:21:
+					    * clear to send requests */

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#484: FILE: drivers/net/txgbe/base/txgbe_mbx.h:79:
+s32 txgbe_read_mbx(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#484: FILE: drivers/net/txgbe/base/txgbe_mbx.h:79:
+s32 txgbe_read_mbx(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#484: FILE: drivers/net/txgbe/base/txgbe_mbx.h:79:
+s32 txgbe_read_mbx(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#484: FILE: drivers/net/txgbe/base/txgbe_mbx.h:79:
+s32 txgbe_read_mbx(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#485: FILE: drivers/net/txgbe/base/txgbe_mbx.h:80:
+s32 txgbe_write_mbx(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#485: FILE: drivers/net/txgbe/base/txgbe_mbx.h:80:
+s32 txgbe_write_mbx(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#485: FILE: drivers/net/txgbe/base/txgbe_mbx.h:80:
+s32 txgbe_write_mbx(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#485: FILE: drivers/net/txgbe/base/txgbe_mbx.h:80:
+s32 txgbe_write_mbx(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#486: FILE: drivers/net/txgbe/base/txgbe_mbx.h:81:
+s32 txgbe_check_for_msg(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#486: FILE: drivers/net/txgbe/base/txgbe_mbx.h:81:
+s32 txgbe_check_for_msg(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#487: FILE: drivers/net/txgbe/base/txgbe_mbx.h:82:
+s32 txgbe_check_for_ack(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#487: FILE: drivers/net/txgbe/base/txgbe_mbx.h:82:
+s32 txgbe_check_for_ack(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#488: FILE: drivers/net/txgbe/base/txgbe_mbx.h:83:
+s32 txgbe_check_for_rst(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#488: FILE: drivers/net/txgbe/base/txgbe_mbx.h:83:
+s32 txgbe_check_for_rst(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#491: FILE: drivers/net/txgbe/base/txgbe_mbx.h:86:
+s32 txgbe_read_mbx_pf(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#491: FILE: drivers/net/txgbe/base/txgbe_mbx.h:86:
+s32 txgbe_read_mbx_pf(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#491: FILE: drivers/net/txgbe/base/txgbe_mbx.h:86:
+s32 txgbe_read_mbx_pf(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#491: FILE: drivers/net/txgbe/base/txgbe_mbx.h:86:
+s32 txgbe_read_mbx_pf(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#492: FILE: drivers/net/txgbe/base/txgbe_mbx.h:87:
+s32 txgbe_write_mbx_pf(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32 *' should also have an identifier name
#492: FILE: drivers/net/txgbe/base/txgbe_mbx.h:87:
+s32 txgbe_write_mbx_pf(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#492: FILE: drivers/net/txgbe/base/txgbe_mbx.h:87:
+s32 txgbe_write_mbx_pf(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#492: FILE: drivers/net/txgbe/base/txgbe_mbx.h:87:
+s32 txgbe_write_mbx_pf(struct txgbe_hw *, u32 *, u16, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#493: FILE: drivers/net/txgbe/base/txgbe_mbx.h:88:
+s32 txgbe_check_for_msg_pf(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#493: FILE: drivers/net/txgbe/base/txgbe_mbx.h:88:
+s32 txgbe_check_for_msg_pf(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#494: FILE: drivers/net/txgbe/base/txgbe_mbx.h:89:
+s32 txgbe_check_for_ack_pf(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#494: FILE: drivers/net/txgbe/base/txgbe_mbx.h:89:
+s32 txgbe_check_for_ack_pf(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#495: FILE: drivers/net/txgbe/base/txgbe_mbx.h:90:
+s32 txgbe_check_for_rst_pf(struct txgbe_hw *, u16);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u16' should also have an identifier name
#495: FILE: drivers/net/txgbe/base/txgbe_mbx.h:90:
+s32 txgbe_check_for_rst_pf(struct txgbe_hw *, u16);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#842: FILE: drivers/net/txgbe/txgbe_pf.c:335:
+	for (i = 0; i < nb_entries; i++) {
+		vfinfo->vf_mc_hashes[i] = hash_list[i];
+	}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_frame < RTE_ETHER_MIN_LEN'
#892: FILE: drivers/net/txgbe/txgbe_pf.c:385:
+	if ((max_frame < RTE_ETHER_MIN_LEN) ||
+			(max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN'
#892: FILE: drivers/net/txgbe/txgbe_pf.c:385:
+	if ((max_frame < RTE_ETHER_MIN_LEN) ||
+			(max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vlana == TXGBE_POOLTAG_ACT_ALWAYS'
#992: FILE: drivers/net/txgbe/txgbe_pf.c:485:
+		if ((vlana == TXGBE_POOLTAG_ACT_ALWAYS) &&
+			((vid !=  0) || (user_priority != 0)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vid !=  0'
#992: FILE: drivers/net/txgbe/txgbe_pf.c:485:
+		if ((vlana == TXGBE_POOLTAG_ACT_ALWAYS) &&
+			((vid !=  0) || (user_priority != 0)))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'user_priority != 0'
#992: FILE: drivers/net/txgbe/txgbe_pf.c:485:
+		if ((vlana == TXGBE_POOLTAG_ACT_ALWAYS) &&
+			((vid !=  0) || (user_priority != 0)))

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1090: FILE: drivers/net/txgbe/txgbe_pf.c:583:
+		if (!rte_is_valid_assigned_ether_addr(

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1200: FILE: drivers/net/txgbe/txgbe_pf.c:693:
+		PMD_DRV_LOG(DEBUG, "Unhandled Msg %8.8x", (unsigned)msgbuf[0]);

total: 0 errors, 34 warnings, 8 checks, 1120 lines checked

          parent reply	other threads:[~2020-10-06  9:43 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20201005120910.189343-40-jiawenwu@trustnetic.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201006094343.CD4352952@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=jiawenwu@trustnetic.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).