* [dpdk-test-report] |WARNING| pw79663 [PATCH v2 44/56] net/txgbe: add flow control support
[not found] <20201005120910.189343-45-jiawenwu@trustnetic.com>
@ 2020-10-06 9:44 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-10-06 9:44 UTC (permalink / raw)
To: test-report; +Cc: Jiawen Wu
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79663
_coding style issues_
WARNING:UNNECESSARY_BREAK: break is not useful after a goto or return
#277: FILE: drivers/net/txgbe/base/txgbe_hw.c:200:
+ goto out;
+ break;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fc_conf->high_water > max_high_water'
#769: FILE: drivers/net/txgbe/txgbe_ethdev.c:2772:
+ if ((fc_conf->high_water > max_high_water) ||
+ (fc_conf->high_water < fc_conf->low_water)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fc_conf->high_water < fc_conf->low_water'
#769: FILE: drivers/net/txgbe/txgbe_ethdev.c:2772:
+ if ((fc_conf->high_water > max_high_water) ||
+ (fc_conf->high_water < fc_conf->low_water)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == 0'
#786: FILE: drivers/net/txgbe/txgbe_ethdev.c:2789:
+ if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == TXGBE_ERR_FC_NOT_NEGOTIATED'
#786: FILE: drivers/net/txgbe/txgbe_ethdev.c:2789:
+ if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED)) {
total: 0 errors, 1 warnings, 4 checks, 708 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-10-06 9:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201005120910.189343-45-jiawenwu@trustnetic.com>
2020-10-06 9:44 ` [dpdk-test-report] |WARNING| pw79663 [PATCH v2 44/56] net/txgbe: add flow control support checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).