From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw79664 [PATCH v2 46/56] net/txgbe: add priority flow control support
Date: Tue, 6 Oct 2020 11:44:16 +0200 (CEST) [thread overview]
Message-ID: <20201006094416.76C8C4C8E@dpdk.org> (raw)
In-Reply-To: <20201005120910.189343-47-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79664
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'map[j] == i'
#286: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.c:214:
+ if ((map[j] == i) && (pfc_en & (1 << j))) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pfc_conf->fc.high_water > max_high_water'
#369: FILE: drivers/net/txgbe/txgbe_ethdev.c:2831:
+ if ((pfc_conf->fc.high_water > max_high_water) ||
+ (pfc_conf->fc.high_water <= pfc_conf->fc.low_water)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pfc_conf->fc.high_water <= pfc_conf->fc.low_water'
#369: FILE: drivers/net/txgbe/txgbe_ethdev.c:2831:
+ if ((pfc_conf->fc.high_water > max_high_water) ||
+ (pfc_conf->fc.high_water <= pfc_conf->fc.low_water)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == 0'
#385: FILE: drivers/net/txgbe/txgbe_ethdev.c:2847:
+ if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == TXGBE_ERR_FC_NOT_NEGOTIATED'
#385: FILE: drivers/net/txgbe/txgbe_ethdev.c:2847:
+ if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED))
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#425: FILE: drivers/net/txgbe/txgbe_rxtx.c:3321:
+ /*
+ * If the TC count is 8,and the default high_water is 48,
total: 0 errors, 1 warnings, 5 checks, 343 lines checked
parent reply other threads:[~2020-10-06 9:44 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201005120910.189343-47-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006094416.76C8C4C8E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).