From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2A1ABA04BB
	for <public@inbox.dpdk.org>; Tue,  6 Oct 2020 11:44:18 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 24BA72C54;
	Tue,  6 Oct 2020 11:44:17 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 76C8C4C8E; Tue,  6 Oct 2020 11:44:16 +0200 (CEST)
In-Reply-To: <20201005120910.189343-47-jiawenwu@trustnetic.com>
References: <20201005120910.189343-47-jiawenwu@trustnetic.com>
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Message-Id: <20201006094416.76C8C4C8E@dpdk.org>
Date: Tue,  6 Oct 2020 11:44:16 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw79664 [PATCH v2 46/56] net/txgbe:
	add priority flow control support
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79664

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'map[j] == i'
#286: FILE: drivers/net/txgbe/base/txgbe_dcb_hw.c:214:
+			if ((map[j] == i) && (pfc_en & (1 << j))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pfc_conf->fc.high_water > max_high_water'
#369: FILE: drivers/net/txgbe/txgbe_ethdev.c:2831:
+	if ((pfc_conf->fc.high_water > max_high_water) ||
+	    (pfc_conf->fc.high_water <= pfc_conf->fc.low_water)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pfc_conf->fc.high_water <= pfc_conf->fc.low_water'
#369: FILE: drivers/net/txgbe/txgbe_ethdev.c:2831:
+	if ((pfc_conf->fc.high_water > max_high_water) ||
+	    (pfc_conf->fc.high_water <= pfc_conf->fc.low_water)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == 0'
#385: FILE: drivers/net/txgbe/txgbe_ethdev.c:2847:
+	if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'err == TXGBE_ERR_FC_NOT_NEGOTIATED'
#385: FILE: drivers/net/txgbe/txgbe_ethdev.c:2847:
+	if ((err == 0) || (err == TXGBE_ERR_FC_NOT_NEGOTIATED))

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#425: FILE: drivers/net/txgbe/txgbe_rxtx.c:3321:
+			/*
+			* If the TC count is 8,and the default high_water is 48,

total: 0 errors, 1 warnings, 5 checks, 343 lines checked