automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jakub Grajciar <jgrajcia@cisco.com>
Subject: [dpdk-test-report] |WARNING| pw79675 [PATCH] net/memif: use abstract socket address
Date: Tue,  6 Oct 2020 11:44:41 +0200 (CEST)	[thread overview]
Message-ID: <20201006094441.38E5C2E81@dpdk.org> (raw)
In-Reply-To: <20201005123900.32723-1-jgrajcia@cisco.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79675

_coding style issues_


WARNING:TYPO_SPELLING: 'dissapears' may be misspelled - perhaps 'disappears'?
#71: 
filesystem pathnames and the socket dissapears

CHECK:BRACES: braces {} should be used on all arms of this statement
#120: FILE: drivers/net/memif/memif_socket.c:889:
+		if (is_abstract) {
[...]
+		} else
[...]

ERROR:C99_COMMENTS: do not use C99 // comments
#121: FILE: drivers/net/memif/memif_socket.c:890:
+			// abstract address

CHECK:BRACES: Unbalanced braces around else statement
#124: FILE: drivers/net/memif/memif_socket.c:893:
+		} else

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#134: FILE: drivers/net/memif/memif_socket.c:971:
+					     (pmd->role == MEMIF_ROLE_SLAVE) ? 0 : 1, pmd->flags & ETH_MEMIF_FLAG_SOCKET_ABSTRACT);

WARNING:LONG_LINE: line over 100 characters
#134: FILE: drivers/net/memif/memif_socket.c:971:
+					     (pmd->role == MEMIF_ROLE_SLAVE) ? 0 : 1, pmd->flags & ETH_MEMIF_FLAG_SOCKET_ABSTRACT);

CHECK:BRACES: braces {} should be used on all arms of this statement
#162: FILE: drivers/net/memif/memif_socket.c:1076:
+	if (pmd->flags & ETH_MEMIF_FLAG_SOCKET_ABSTRACT) {
[...]
+	} else
[...]

ERROR:C99_COMMENTS: do not use C99 // comments
#163: FILE: drivers/net/memif/memif_socket.c:1077:
+		// abstract address

CHECK:BRACES: Unbalanced braces around else statement
#166: FILE: drivers/net/memif/memif_socket.c:1080:
+	} else

ERROR:C99_COMMENTS: do not use C99 // comments
#220: FILE: drivers/net/memif/rte_eth_memif.c:1747:
+	// use abstract address by default

ERROR:TRAILING_WHITESPACE: trailing whitespace
#243: FILE: drivers/net/memif/rte_eth_memif.c:1795:
+^I^Iif (ret < 0)^I$

total: 4 errors, 3 warnings, 4 checks, 166 lines checked

      parent reply	other threads:[~2020-10-06  9:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201005123900.32723-1-jgrajcia@cisco.com>
2020-10-05 13:57 ` [dpdk-test-report] |SUCCESS| pw79675 " 0-day Robot
2020-10-06  9:44 ` checkpatch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201006094441.38E5C2E81@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=jgrajcia@cisco.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).