From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 35F01A04BB
	for <public@inbox.dpdk.org>; Tue,  6 Oct 2020 11:44:43 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 2A17C4C93;
	Tue,  6 Oct 2020 11:44:42 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 38E5C2E81; Tue,  6 Oct 2020 11:44:41 +0200 (CEST)
In-Reply-To: <20201005123900.32723-1-jgrajcia@cisco.com>
References: <20201005123900.32723-1-jgrajcia@cisco.com>
To: test-report@dpdk.org
Cc: Jakub Grajciar <jgrajcia@cisco.com>
Message-Id: <20201006094441.38E5C2E81@dpdk.org>
Date: Tue,  6 Oct 2020 11:44:41 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw79675 [PATCH] net/memif: use
	abstract socket address
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79675

_coding style issues_


WARNING:TYPO_SPELLING: 'dissapears' may be misspelled - perhaps 'disappears'?
#71: 
filesystem pathnames and the socket dissapears

CHECK:BRACES: braces {} should be used on all arms of this statement
#120: FILE: drivers/net/memif/memif_socket.c:889:
+		if (is_abstract) {
[...]
+		} else
[...]

ERROR:C99_COMMENTS: do not use C99 // comments
#121: FILE: drivers/net/memif/memif_socket.c:890:
+			// abstract address

CHECK:BRACES: Unbalanced braces around else statement
#124: FILE: drivers/net/memif/memif_socket.c:893:
+		} else

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#134: FILE: drivers/net/memif/memif_socket.c:971:
+					     (pmd->role == MEMIF_ROLE_SLAVE) ? 0 : 1, pmd->flags & ETH_MEMIF_FLAG_SOCKET_ABSTRACT);

WARNING:LONG_LINE: line over 100 characters
#134: FILE: drivers/net/memif/memif_socket.c:971:
+					     (pmd->role == MEMIF_ROLE_SLAVE) ? 0 : 1, pmd->flags & ETH_MEMIF_FLAG_SOCKET_ABSTRACT);

CHECK:BRACES: braces {} should be used on all arms of this statement
#162: FILE: drivers/net/memif/memif_socket.c:1076:
+	if (pmd->flags & ETH_MEMIF_FLAG_SOCKET_ABSTRACT) {
[...]
+	} else
[...]

ERROR:C99_COMMENTS: do not use C99 // comments
#163: FILE: drivers/net/memif/memif_socket.c:1077:
+		// abstract address

CHECK:BRACES: Unbalanced braces around else statement
#166: FILE: drivers/net/memif/memif_socket.c:1080:
+	} else

ERROR:C99_COMMENTS: do not use C99 // comments
#220: FILE: drivers/net/memif/rte_eth_memif.c:1747:
+	// use abstract address by default

ERROR:TRAILING_WHITESPACE: trailing whitespace
#243: FILE: drivers/net/memif/rte_eth_memif.c:1795:
+^I^Iif (ret < 0)^I$

total: 4 errors, 3 warnings, 4 checks, 166 lines checked