From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Kiran KN <kirankn@juniper.net>
Subject: [dpdk-test-report] |WARNING| pw80275 [PATCH] net/bonding: LACP Packet statistics support
Date: Sat, 10 Oct 2020 12:20:44 +0200 (CEST) [thread overview]
Message-ID: <20201010102044.D4E531D8F0@dpdk.org> (raw)
In-Reply-To: <96073106-5E60-4CBC-8885-B2A6CDDD40B8@juniper.net>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/80275
_coding style issues_
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#146:
Store the LACP packets sent and received for each slave.
WARNING:BAD_SIGN_OFF: 'Signed-off-by:' is the preferred signature form
#149:
Signed-Off-By: Kiran K N <kirankn@juniper.net>
ERROR:GERRIT_CHANGE_ID: Remove Gerrit Change-Id's before submitting upstream
#151:
Change-Id: Iae82bd7d0879a4c4333a292c96d431798c56e301
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#173: FILE: drivers/net/bonding/eth_bond_8023ad_private.h:22:
+/** maximum number of slaves for each port */
WARNING:TYPO_SPELLING: 'SLAVES' may be misspelled - perhaps 'SECONDARIES'?
#174: FILE: drivers/net/bonding/eth_bond_8023ad_private.h:23:
+#define BOND_MODE_8023AD_MAX_SLAVES 6
WARNING:TYPO_SPELLING: 'SLAVES' may be misspelled - perhaps 'SECONDARIES'?
#186: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:135:
+static uint64_t lacpdu_tx_count[BOND_MODE_8023AD_MAX_SLAVES];
WARNING:TYPO_SPELLING: 'SLAVES' may be misspelled - perhaps 'SECONDARIES'?
#187: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:136:
+static uint64_t lacpdu_rx_count[BOND_MODE_8023AD_MAX_SLAVES];
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#196: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:635:
+lacpdu_tx_count[slave_id]++;
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#204: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:645:
+lacpdu_tx_count[slave_id] += pkts_sent;
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 4)
#213: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:905:
+if (retval == 0) {
+ lacpdu_rx_count[slave_id]++;
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#214: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:906:
+ lacpdu_rx_count[slave_id]++;
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#214: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:906:
+ lacpdu_rx_count[slave_id]++;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#215: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:907:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#215: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:907:
+ }$
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#224: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:919:
+lacpdu_rx_count[slave_id] += rx_count;
WARNING:TYPO_SPELLING: 'SLAVES' may be misspelled - perhaps 'SECONDARIES'?
#236: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1733:
+if(port_id > BOND_MODE_8023AD_MAX_SLAVES)
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#236: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1733:
+if(port_id > BOND_MODE_8023AD_MAX_SLAVES)
+return -1;
ERROR:SPACING: space required before the open parenthesis '('
#236: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1733:
+if(port_id > BOND_MODE_8023AD_MAX_SLAVES)
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#239: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1736:
+if(clear) {
+lacpdu_tx_count[port_id] = 0;
ERROR:SPACING: space required before the open parenthesis '('
#239: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1736:
+if(clear) {
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#244: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1741:
+ return lacpdu_tx_count[port_id];$
WARNING:TYPO_SPELLING: 'SLAVES' may be misspelled - perhaps 'SECONDARIES'?
#250: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1747:
+if(port_id > BOND_MODE_8023AD_MAX_SLAVES)
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#250: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1747:
+if(port_id > BOND_MODE_8023AD_MAX_SLAVES)
+return -1;
ERROR:SPACING: space required before the open parenthesis '('
#250: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1747:
+if(port_id > BOND_MODE_8023AD_MAX_SLAVES)
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#253: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1750:
+if(clear) {
+lacpdu_rx_count[port_id] = 0;
ERROR:SPACING: space required before the open parenthesis '('
#253: FILE: drivers/net/bonding/rte_eth_bond_8023ad.c:1750:
+if(clear) {
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#270: FILE: drivers/net/bonding/rte_eth_bond_8023ad.h:345:
+ * Get Lacp statistics counter for slaves
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#271: FILE: drivers/net/bonding/rte_eth_bond_8023ad.h:346:
+ * @param port_id Bonding slave device id
WARNING:TYPO_SPELLING: 'slaves' may be misspelled - perhaps 'secondaries'?
#280: FILE: drivers/net/bonding/rte_eth_bond_8023ad.h:355:
+ * Get Lacp statistics counter for slaves
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#281: FILE: drivers/net/bonding/rte_eth_bond_8023ad.h:356:
+ * @param port_id Bonding slave device id
WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Kiran KN <kirankn@juniper.net>'
total: 6 errors, 25 warnings, 0 checks, 104 lines checked
parent reply other threads:[~2020-10-10 10:20 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <96073106-5E60-4CBC-8885-B2A6CDDD40B8@juniper.net>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201010102044.D4E531D8F0@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=kirankn@juniper.net \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).