automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw81318 [PATCH v4 33/58] net/txgbe: add device stats get
       [not found] <20201019085415.82207-34-jiawenwu@trustnetic.com>
@ 2020-10-19  9:07 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-10-19  9:07 UTC (permalink / raw)
  To: test-report; +Cc: Jiawen Wu

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/81318

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last_counter' - possible side-effects?
#376: FILE: drivers/net/txgbe/txgbe_ethdev.c:953:
+#define UPDATE_QP_COUNTER_32bit(reg, last_counter, counter)     \
+	{                                                       \
+		uint32_t current_counter = rd32(hw, reg);       \
+		if (current_counter < last_counter)             \
+			current_counter += 0x100000000LL;       \
+		if (!hw->offset_loaded)                         \
+			last_counter = current_counter;         \
+		counter = current_counter - last_counter;       \
+		counter &= 0xFFFFFFFFLL;                        \
+	}

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'last_counter' may be better as '(last_counter)' to avoid precedence issues
#376: FILE: drivers/net/txgbe/txgbe_ethdev.c:953:
+#define UPDATE_QP_COUNTER_32bit(reg, last_counter, counter)     \
+	{                                                       \
+		uint32_t current_counter = rd32(hw, reg);       \
+		if (current_counter < last_counter)             \
+			current_counter += 0x100000000LL;       \
+		if (!hw->offset_loaded)                         \
+			last_counter = current_counter;         \
+		counter = current_counter - last_counter;       \
+		counter &= 0xFFFFFFFFLL;                        \
+	}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'counter' - possible side-effects?
#376: FILE: drivers/net/txgbe/txgbe_ethdev.c:953:
+#define UPDATE_QP_COUNTER_32bit(reg, last_counter, counter)     \
+	{                                                       \
+		uint32_t current_counter = rd32(hw, reg);       \
+		if (current_counter < last_counter)             \
+			current_counter += 0x100000000LL;       \
+		if (!hw->offset_loaded)                         \
+			last_counter = current_counter;         \
+		counter = current_counter - last_counter;       \
+		counter &= 0xFFFFFFFFLL;                        \
+	}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last_counter' - possible side-effects?
#387: FILE: drivers/net/txgbe/txgbe_ethdev.c:964:
+#define UPDATE_QP_COUNTER_36bit(reg_lsb, reg_msb, last_counter, counter) \
+	{                                                                \
+		uint64_t current_counter_lsb = rd32(hw, reg_lsb);        \
+		uint64_t current_counter_msb = rd32(hw, reg_msb);        \
+		uint64_t current_counter = (current_counter_msb << 32) | \
+			current_counter_lsb;                             \
+		if (current_counter < last_counter)                      \
+			current_counter += 0x1000000000LL;               \
+		if (!hw->offset_loaded)                                  \
+			last_counter = current_counter;                  \
+		counter = current_counter - last_counter;                \
+		counter &= 0xFFFFFFFFFLL;                                \
+	}

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'last_counter' may be better as '(last_counter)' to avoid precedence issues
#387: FILE: drivers/net/txgbe/txgbe_ethdev.c:964:
+#define UPDATE_QP_COUNTER_36bit(reg_lsb, reg_msb, last_counter, counter) \
+	{                                                                \
+		uint64_t current_counter_lsb = rd32(hw, reg_lsb);        \
+		uint64_t current_counter_msb = rd32(hw, reg_msb);        \
+		uint64_t current_counter = (current_counter_msb << 32) | \
+			current_counter_lsb;                             \
+		if (current_counter < last_counter)                      \
+			current_counter += 0x1000000000LL;               \
+		if (!hw->offset_loaded)                                  \
+			last_counter = current_counter;                  \
+		counter = current_counter - last_counter;                \
+		counter &= 0xFFFFFFFFFLL;                                \
+	}

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'counter' - possible side-effects?
#387: FILE: drivers/net/txgbe/txgbe_ethdev.c:964:
+#define UPDATE_QP_COUNTER_36bit(reg_lsb, reg_msb, last_counter, counter) \
+	{                                                                \
+		uint64_t current_counter_lsb = rd32(hw, reg_lsb);        \
+		uint64_t current_counter_msb = rd32(hw, reg_msb);        \
+		uint64_t current_counter = (current_counter_msb << 32) | \
+			current_counter_lsb;                             \
+		if (current_counter < last_counter)                      \
+			current_counter += 0x1000000000LL;               \
+		if (!hw->offset_loaded)                                  \
+			last_counter = current_counter;                  \
+		counter = current_counter - last_counter;                \
+		counter &= 0xFFFFFFFFFLL;                                \
+	}

total: 0 errors, 0 warnings, 6 checks, 594 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-10-19  9:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20201019085415.82207-34-jiawenwu@trustnetic.com>
2020-10-19  9:07 ` [dpdk-test-report] |WARNING| pw81318 [PATCH v4 33/58] net/txgbe: add device stats get checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).