From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BE985A04DD
	for <public@inbox.dpdk.org>; Tue, 20 Oct 2020 11:29:31 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 12A10BCE2;
	Tue, 20 Oct 2020 11:29:23 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 51C02AD77; Tue, 20 Oct 2020 11:29:20 +0200 (CEST)
In-Reply-To: <1603185222-14831-21-git-send-email-arybchenko@solarflare.com>
References: <1603185222-14831-21-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20201020092920.51C02AD77@dpdk.org>
Date: Tue, 20 Oct 2020 11:29:20 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw81536 [PATCH v2 20/62]
	common/sfc_efx/base: support adding DELIVER action to a set
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/81536

_coding style issues_


WARNING:SPACING: space prohibited between function name and open parenthesis '('
#177: FILE: drivers/common/sfc_efx/base/efx_mae.c:652:
+	if (arg_size != sizeof (spec->emass_deliver_mport)) {

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#189: FILE: drivers/common/sfc_efx/base/efx_mae.c:664:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#195: FILE: drivers/common/sfc_efx/base/efx_mae.c:670:
+	return (rc);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_mae_actions_t *' should also have an identifier name
#200: FILE: drivers/common/sfc_efx/base/efx_mae.c:675:
+	efx_rc_t	(*emad_add)(efx_mae_actions_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'size_t' should also have an identifier name
#200: FILE: drivers/common/sfc_efx/base/efx_mae.c:675:
+	efx_rc_t	(*emad_add)(efx_mae_actions_t *,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'const uint8_t *' should also have an identifier name
#200: FILE: drivers/common/sfc_efx/base/efx_mae.c:675:
+	efx_rc_t	(*emad_add)(efx_mae_actions_t *,

ERROR:INITIALISED_STATIC: do not initialise statics to 0
#213: FILE: drivers/common/sfc_efx/base/efx_mae.c:688:
+static const uint32_t efx_mae_action_repeat_map = 0;

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#232: FILE: drivers/common/sfc_efx/base/efx_mae.c:707:
+	    (sizeof (efx_mae_action_ordered_map) * 8));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#234: FILE: drivers/common/sfc_efx/base/efx_mae.c:709:
+	    (sizeof (efx_mae_action_repeat_map) * 8));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#274: FILE: drivers/common/sfc_efx/base/efx_mae.c:749:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#284: FILE: drivers/common/sfc_efx/base/efx_mae.c:759:
+	return (rc);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#303: FILE: drivers/common/sfc_efx/base/efx_mae.c:778:
+	    EFX_MAE_ACTION_DELIVER, sizeof (mportp->sel), arg));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#307: FILE: drivers/common/sfc_efx/base/efx_mae.c:782:
+	return (rc);

total: 6 errors, 7 warnings, 199 lines checked