Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/84259 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: <_Pragma> #318: FILE: drivers/net/virtio/virtio_rxtx_packed.h:52: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #318: FILE: drivers/net/virtio/virtio_rxtx_packed.h:52: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #318: FILE: drivers/net/virtio/virtio_rxtx_packed.h:52: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues #318: FILE: drivers/net/virtio/virtio_rxtx_packed.h:52: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \ + for (iter = val; iter < size; iter++) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #323: FILE: drivers/net/virtio/virtio_rxtx_packed.h:57: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #323: FILE: drivers/net/virtio/virtio_rxtx_packed.h:57: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues #323: FILE: drivers/net/virtio/virtio_rxtx_packed.h:57: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \ + for (iter = val; iter < size; iter++) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #328: FILE: drivers/net/virtio/virtio_rxtx_packed.h:62: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #328: FILE: drivers/net/virtio/virtio_rxtx_packed.h:62: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues #328: FILE: drivers/net/virtio/virtio_rxtx_packed.h:62: +#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #333: FILE: drivers/net/virtio/virtio_rxtx_packed.h:67: +#define virtio_for_each_try_unroll(iter, val, size) \ + for (iter = val; iter < size; iter++) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues #333: FILE: drivers/net/virtio/virtio_rxtx_packed.h:67: +#define virtio_for_each_try_unroll(iter, val, size) \ + for (iter = val; iter < size; iter++) total: 3 errors, 0 warnings, 9 checks, 708 lines checked