automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw85421 [PATCH v3 14/33] net/txgbe: configure flow director filter
       [not found] <20201218093702.3651867-15-jiawenwu@trustnetic.com>
@ 2020-12-18  9:39 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-12-18  9:39 UTC (permalink / raw)
  To: test-report; +Cc: Jiawen Wu

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/85421

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ipv6m' - possible side-effects?
#174: FILE: drivers/net/txgbe/txgbe_fdir.c:19:
+#define IPV6_ADDR_TO_MASK(ipaddr, ipv6m) do { \
+	uint8_t ipv6_addr[16]; \
+	uint8_t i; \
+	rte_memcpy(ipv6_addr, (ipaddr), sizeof(ipv6_addr));\
+	(ipv6m) = 0; \
+	for (i = 0; i < sizeof(ipv6_addr); i++) { \
+		if (ipv6_addr[i] == UINT8_MAX) \
+			(ipv6m) |= 1 << i; \
+		else if (ipv6_addr[i] != 0) { \
+			PMD_DRV_LOG(ERR, " invalid IPv6 address mask."); \
+			return -EINVAL; \
+		} \
+	} \
+} while (0)

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#174: FILE: drivers/net/txgbe/txgbe_fdir.c:19:
+#define IPV6_ADDR_TO_MASK(ipaddr, ipv6m) do { \
+	uint8_t ipv6_addr[16]; \
+	uint8_t i; \
+	rte_memcpy(ipv6_addr, (ipaddr), sizeof(ipv6_addr));\
+	(ipv6m) = 0; \
+	for (i = 0; i < sizeof(ipv6_addr); i++) { \
+		if (ipv6_addr[i] == UINT8_MAX) \
+			(ipv6m) |= 1 << i; \
+		else if (ipv6_addr[i] != 0) { \
+			PMD_DRV_LOG(ERR, " invalid IPv6 address mask."); \
+			return -EINVAL; \
+		} \
+	} \
+} while (0)

total: 0 errors, 1 warnings, 1 checks, 491 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-12-18  9:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20201218093702.3651867-15-jiawenwu@trustnetic.com>
2020-12-18  9:39 ` [dpdk-test-report] |WARNING| pw85421 [PATCH v3 14/33] net/txgbe: configure flow director filter checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).