automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw85438 [PATCH v3 30/33] net/txgbe: add security session create operation
Date: Fri, 18 Dec 2020 10:45:19 +0100 (CET)	[thread overview]
Message-ID: <20201218094519.08E13CABF@dpdk.org> (raw)
In-Reply-To: <20201218093702.3651867-31-jiawenwu@trustnetic.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/85438

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'a' - possible side-effects?
#113: FILE: drivers/net/txgbe/txgbe_ipsec.c:13:
+#define CMP_IP(a, b) (\
+	(a).ipv6[0] == (b).ipv6[0] && \
+	(a).ipv6[1] == (b).ipv6[1] && \
+	(a).ipv6[2] == (b).ipv6[2] && \
+	(a).ipv6[3] == (b).ipv6[3])

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects?
#113: FILE: drivers/net/txgbe/txgbe_ipsec.c:13:
+#define CMP_IP(a, b) (\
+	(a).ipv6[0] == (b).ipv6[0] && \
+	(a).ipv6[1] == (b).ipv6[1] && \
+	(a).ipv6[2] == (b).ipv6[2] && \
+	(a).ipv6[3] == (b).ipv6[3])

CHECK:CAMELCASE: Avoid CamelCase: <IPv6>
#187: FILE: drivers/net/txgbe/txgbe_ipsec.c:87:
+		if (ic_session->dst_ip.type == IPv6) {

CHECK:CAMELCASE: Avoid CamelCase: <IPv4>
#190: FILE: drivers/net/txgbe/txgbe_ipsec.c:90:
+		} else if (ic_session->dst_ip.type == IPv4) {

total: 0 errors, 0 warnings, 4 checks, 367 lines checked

           reply	other threads:[~2020-12-18  9:45 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20201218093702.3651867-31-jiawenwu@trustnetic.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201218094519.08E13CABF@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=jiawenwu@trustnetic.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).