From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A339DA09EF
	for <public@inbox.dpdk.org>; Sat, 26 Dec 2020 17:58:53 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 9CB7E6938;
	Sat, 26 Dec 2020 17:58:52 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 1017)
 id A137C69FB; Sat, 26 Dec 2020 17:58:51 +0100 (CET)
In-Reply-To: <20201226165714.4416-1-talshn@nvidia.com>
References: <20201226165714.4416-1-talshn@nvidia.com>
To: test-report@dpdk.org
Cc: Tal Shnaiderman <talshn@nvidia.com>
Message-Id: <20201226165851.A137C69FB@dpdk.org>
Date: Sat, 26 Dec 2020 17:58:51 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw85738 [PATCH] mlx5: split
	multi-threaded flows per OS
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/85738

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#101: FILE: drivers/net/mlx5/linux/mlx5_flow_os.c:17:
+		return ENOMEM;

CHECK:CAMELCASE: Avoid CamelCase: <WaitForSingleObject>
#286: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:261:
+	DWORD result = WaitForSingleObject(thread_handle, 0);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#288: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:263:
+	if (result == WAIT_OBJECT_0) {
+		return false;
+	}

CHECK:CAMELCASE: Avoid CamelCase: <DuplicateHandle>
#297: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:272:
+	BOOL ret = DuplicateHandle(GetCurrentProcess(), GetCurrentThread(),

CHECK:CAMELCASE: Avoid CamelCase: <GetCurrentProcess>
#297: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:272:
+	BOOL ret = DuplicateHandle(GetCurrentProcess(), GetCurrentThread(),

CHECK:CAMELCASE: Avoid CamelCase: <GetCurrentThread>
#297: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:272:
+	BOOL ret = DuplicateHandle(GetCurrentProcess(), GetCurrentThread(),

CHECK:CAMELCASE: Avoid CamelCase: <CloseHandle>
#333: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:308:
+			CloseHandle(temp->thread_handle);

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#384: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:359:
+		first = curr = temp;

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#386: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:361:
+	}
+	else {

CHECK:BRACES: Unbalanced braces around else statement
#386: FILE: drivers/net/mlx5/windows/mlx5_flow_os.c:361:
+	else {

total: 1 errors, 2 warnings, 7 checks, 333 lines checked