From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37436A09FF for ; Thu, 7 Jan 2021 08:29:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D185140E95; Thu, 7 Jan 2021 08:29:46 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mails.dpdk.org (Postfix) with ESMTP id 6212F140E95 for ; Thu, 7 Jan 2021 08:29:44 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id 591E32B9D; Thu, 7 Jan 2021 08:29:44 +0100 (CET) In-Reply-To: <20210107071503.14720-3-jingjing.wu@intel.com> References: <20210107071503.14720-3-jingjing.wu@intel.com> To: test-report@dpdk.org Cc: Jingjing Wu Message-Id: <20210107072944.591E32B9D@dpdk.org> Date: Thu, 7 Jan 2021 08:29:44 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw86086 [PATCH v2 2/6] net/iavf_be: control queue enabling X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/86086 _coding style issues_ WARNING:TYPO_SPELLING: 'implemention' may be misspelled - perhaps 'implementation'? #61: 2. Emu device callback functions implemention. ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #88: FILE: drivers/net/iavf_be/iavf_be.h:13: +#define IAVFBE_WRITE_32(addr, val) \ + *(volatile uint32_t *)(addr) = rte_cpu_to_le_32(val); WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #88: FILE: drivers/net/iavf_be/iavf_be.h:13: +#define IAVFBE_WRITE_32(addr, val) \ + *(volatile uint32_t *)(addr) = rte_cpu_to_le_32(val); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around adapter->mem_table #208: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:148: + struct rte_iavf_emu_mem **mem = &(adapter->mem_table); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around adapter->mem_table #312: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:252: + struct rte_iavf_emu_mem **mem = &(adapter->mem_table); CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #388: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:328: + +} CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #413: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:353: + +} WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #500: FILE: drivers/net/iavf_be/iavf_be_ethdev.c:481: + * done when emu device is ready.*/ CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #619: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:86: + buf_va = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #687: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:154: + buf_va = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #746: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:213: + asq->ring = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #755: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:222: + arq->ring = (void *)(uintptr_t)rte_iavf_emu_get_dma_vaddr( WARNING:TYPO_SPELLING: 'initilized' may be misspelled - perhaps 'initialized'? #780: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:247: + /* Check if control queue is initilized */ WARNING:MISSING_SPACE: break quoted strings at a space character #798: FILE: drivers/net/iavf_be/iavf_be_vchnl.c:265: + IAVF_BE_LOG(DEBUG, "Failed to read msg" + "from AdminQ"); total: 1 errors, 5 warnings, 8 checks, 726 lines checked Warning in drivers/net/iavf_be/iavf_be_ethdev.c: Using rte_atomicNN_xxx