From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Li Feng <fengli@smartx.com>
Subject: [dpdk-test-report] |WARNING| pw87839 [PATCH v3] log: support custom log function
Date: Tue, 16 Feb 2021 10:35:50 +0100 (CET) [thread overview]
Message-ID: <20210216093550.E8900C906@dpdk.org> (raw)
In-Reply-To: <20210210052019.802387-1-fengli@smartx.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/87839
_coding style issues_
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#130: FILE: lib/librte_eal/include/rte_log.h:116:
+rte_log_sink_set(rte_log_write_function* logf);
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#162: FILE: lib/librte_eal/linux/eal_log.c:71:
+rte_log_sink_set(rte_log_write_function* logf)
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#164: FILE: lib/librte_eal/linux/eal_log.c:73:
+ console_log_func.write = logf;$
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#171: FILE: lib/librte_eal/linux/eal_log.c:80:
+rte_log_write_function*
+rte_log_sink_get(void) {
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#173: FILE: lib/librte_eal/linux/eal_log.c:82:
+ return console_log_func.write;$
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#202: FILE: lib/librte_eal/windows/eal_log.c:23:
+rte_log_sink_set(rte_log_write_function* logf)
WARNING:RETURN_VOID: void function return statements are not generally useful
#206: FILE: lib/librte_eal/windows/eal_log.c:27:
+ return;
+}
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#211: FILE: lib/librte_eal/windows/eal_log.c:32:
+rte_log_write_function*
+rte_log_sink_get(void) {
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#213: FILE: lib/librte_eal/windows/eal_log.c:34:
+ return NULL;$
total: 5 errors, 4 warnings, 89 lines checked
next parent reply other threads:[~2021-02-16 9:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210210052019.802387-1-fengli@smartx.com>
2021-02-16 9:35 ` checkpatch [this message]
2021-02-10 6:36 [dpdk-test-report] |WARNING| pw87839 [PATCH] [v3] " dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210216093550.E8900C906@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=fengli@smartx.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).