From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0D489A0550
	for <public@inbox.dpdk.org>; Tue, 16 Feb 2021 10:35:52 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 08EC21606D4;
	Tue, 16 Feb 2021 10:35:52 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.14.124])
 by mails.dpdk.org (Postfix) with ESMTP id EC1281606CC
 for <test-report@dpdk.org>; Tue, 16 Feb 2021 10:35:50 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 1017)
 id E8900C906; Tue, 16 Feb 2021 10:35:50 +0100 (CET)
In-Reply-To: <20210210052019.802387-1-fengli@smartx.com>
References: <20210210052019.802387-1-fengli@smartx.com>
To: test-report@dpdk.org
Cc: Li Feng <fengli@smartx.com>
Message-Id: <20210216093550.E8900C906@dpdk.org>
Date: Tue, 16 Feb 2021 10:35:50 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw87839 [PATCH v3] log: support custom
 log function
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/87839

_coding style issues_


ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#130: FILE: lib/librte_eal/include/rte_log.h:116:
+rte_log_sink_set(rte_log_write_function* logf);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#162: FILE: lib/librte_eal/linux/eal_log.c:71:
+rte_log_sink_set(rte_log_write_function* logf)

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#164: FILE: lib/librte_eal/linux/eal_log.c:73:
+    console_log_func.write = logf;$

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#171: FILE: lib/librte_eal/linux/eal_log.c:80:
+rte_log_write_function*
+rte_log_sink_get(void) {

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#173: FILE: lib/librte_eal/linux/eal_log.c:82:
+    return console_log_func.write;$

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#202: FILE: lib/librte_eal/windows/eal_log.c:23:
+rte_log_sink_set(rte_log_write_function* logf)

WARNING:RETURN_VOID: void function return statements are not generally useful
#206: FILE: lib/librte_eal/windows/eal_log.c:27:
+	return;
+}

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#211: FILE: lib/librte_eal/windows/eal_log.c:32:
+rte_log_write_function*
+rte_log_sink_get(void) {

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#213: FILE: lib/librte_eal/windows/eal_log.c:34:
+    return NULL;$

total: 5 errors, 4 warnings, 89 lines checked