automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw88008 [PATCH 5/7] net/qede: changes for DMA page chain allocation and free
       [not found] <20210219101422.19121-6-rmody@marvell.com>
@ 2021-02-19 10:16 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-02-19 10:16 UTC (permalink / raw)
  To: test-report; +Cc: Rasesh Mody

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/88008

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'elem_size' - possible side-effects?
#274: FILE: drivers/net/qede/base/ecore_chain.h:173:
+#define USABLE_ELEMS_PER_PAGE(elem_size, page_size, mode)		\
+	  ((u32)(ELEMS_PER_PAGE(page_size, elem_size) -			\
+	   UNUSABLE_ELEMS_PER_PAGE(elem_size, mode)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#392: FILE: drivers/net/qede/base/ecore_chain.h:383:
+#define test_and_skip(p, idx)							\
+	do {									\
+		if (is_chain_u16(p)) {						\
+			if (is_unusable_idx(p, idx))				\
+				(p)->u.chain16.idx += (p)->elem_unusable;	\
+		} else {							\
+			if (is_unusable_idx_u32(p, idx))			\
+				(p)->u.chain32.idx += (p)->elem_unusable;	\
+		}								\
 	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#392: FILE: drivers/net/qede/base/ecore_chain.h:383:
+#define test_and_skip(p, idx)							\
+	do {									\
+		if (is_chain_u16(p)) {						\
+			if (is_unusable_idx(p, idx))				\
+				(p)->u.chain16.idx += (p)->elem_unusable;	\
+		} else {							\
+			if (is_unusable_idx_u32(p, idx))			\
+				(p)->u.chain32.idx += (p)->elem_unusable;	\
+		}								\
 	} while (0)

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#701: FILE: drivers/net/qede/base/ecore_dev.c:7857:
+			  "The actual chain size (0x%" PRIx64 ") is larger than the maximal possible value
",

total: 0 errors, 0 warnings, 4 checks, 975 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-02-19 10:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210219101422.19121-6-rmody@marvell.com>
2021-02-19 10:16 ` [dpdk-test-report] |WARNING| pw88008 [PATCH 5/7] net/qede: changes for DMA page chain allocation and free checkpatch

automatic DPDK test reports

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/test-report/0 test-report/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 test-report test-report/ https://inbox.dpdk.org/test-report \
		test-report@dpdk.org
	public-inbox-index test-report

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.test-report


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git