From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0FC66A054A
	for <public@inbox.dpdk.org>; Fri, 19 Feb 2021 11:16:29 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0B9111608D7;
	Fri, 19 Feb 2021 11:16:29 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.14.124])
 by mails.dpdk.org (Postfix) with ESMTP id 346D61608D3
 for <test-report@dpdk.org>; Fri, 19 Feb 2021 11:16:28 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 1017)
 id 3055FC966; Fri, 19 Feb 2021 11:16:28 +0100 (CET)
In-Reply-To: <20210219101422.19121-6-rmody@marvell.com>
References: <20210219101422.19121-6-rmody@marvell.com>
To: test-report@dpdk.org
Cc: Rasesh Mody <rmody@marvell.com>
Message-Id: <20210219101628.3055FC966@dpdk.org>
Date: Fri, 19 Feb 2021 11:16:28 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw88008 [PATCH 5/7] net/qede: changes
 for DMA page chain allocation and free
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/88008

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'elem_size' - possible side-effects?
#274: FILE: drivers/net/qede/base/ecore_chain.h:173:
+#define USABLE_ELEMS_PER_PAGE(elem_size, page_size, mode)		\
+	  ((u32)(ELEMS_PER_PAGE(page_size, elem_size) -			\
+	   UNUSABLE_ELEMS_PER_PAGE(elem_size, mode)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#392: FILE: drivers/net/qede/base/ecore_chain.h:383:
+#define test_and_skip(p, idx)							\
+	do {									\
+		if (is_chain_u16(p)) {						\
+			if (is_unusable_idx(p, idx))				\
+				(p)->u.chain16.idx += (p)->elem_unusable;	\
+		} else {							\
+			if (is_unusable_idx_u32(p, idx))			\
+				(p)->u.chain32.idx += (p)->elem_unusable;	\
+		}								\
 	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#392: FILE: drivers/net/qede/base/ecore_chain.h:383:
+#define test_and_skip(p, idx)							\
+	do {									\
+		if (is_chain_u16(p)) {						\
+			if (is_unusable_idx(p, idx))				\
+				(p)->u.chain16.idx += (p)->elem_unusable;	\
+		} else {							\
+			if (is_unusable_idx_u32(p, idx))			\
+				(p)->u.chain32.idx += (p)->elem_unusable;	\
+		}								\
 	} while (0)

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#701: FILE: drivers/net/qede/base/ecore_dev.c:7857:
+			  "The actual chain size (0x%" PRIx64 ") is larger than the maximal possible value
",

total: 0 errors, 0 warnings, 4 checks, 975 lines checked