automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw88012 [PATCH 4/7] net/qede/base: update base driver to 8.62.4.0
       [not found] <20210219101422.19121-5-rmody@marvell.com>
@ 2021-02-19 11:20 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-02-19 11:20 UTC (permalink / raw)
  To: test-report; +Cc: Rasesh Mody

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/88012

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'cid' - possible side-effects?
#293: FILE: drivers/net/qede/base/ecore.h:166:
+#define DB_ADDR_VF(dev, cid, DEMS) \
+	(ECORE_IS_E4(dev) ? DB_ADDR_VF_E4(cid, DEMS) : DB_ADDR_VF_E5(cid, DEMS))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'DEMS' - possible side-effects?
#293: FILE: drivers/net/qede/base/ecore.h:166:
+#define DB_ADDR_VF(dev, cid, DEMS) \
+	(ECORE_IS_E4(dev) ? DB_ADDR_VF_E4(cid, DEMS) : DB_ADDR_VF_E5(cid, DEMS))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'P_DEV' - possible side-effects?
#318: FILE: drivers/net/qede/base/ecore.h:197:
+#define DP_INT_LOG(P_DEV, LEVEL, MODULE, fmt, ...)		\
+do {								\
+	if (OSAL_UNLIKELY((P_DEV)->dp_int_level > (LEVEL)))	\
+		break;						\
+	if (OSAL_UNLIKELY((P_DEV)->dp_int_level == ECORE_LEVEL_VERBOSE) && \
+	    ((LEVEL) == ECORE_LEVEL_VERBOSE) &&			\
+	    ((P_DEV)->dp_int_module & (MODULE)) == 0)		\
+		break;						\
+								\
+	OSAL_INT_DBG_STORE(P_DEV, fmt,				\
+				__func__, __LINE__,		\
+				(P_DEV)->name ? (P_DEV)->name : "",	\
+				##__VA_ARGS__);		\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'LEVEL' - possible side-effects?
#318: FILE: drivers/net/qede/base/ecore.h:197:
+#define DP_INT_LOG(P_DEV, LEVEL, MODULE, fmt, ...)		\
+do {								\
+	if (OSAL_UNLIKELY((P_DEV)->dp_int_level > (LEVEL)))	\
+		break;						\
+	if (OSAL_UNLIKELY((P_DEV)->dp_int_level == ECORE_LEVEL_VERBOSE) && \
+	    ((LEVEL) == ECORE_LEVEL_VERBOSE) &&			\
+	    ((P_DEV)->dp_int_module & (MODULE)) == 0)		\
+		break;						\
+								\
+	OSAL_INT_DBG_STORE(P_DEV, fmt,				\
+				__func__, __LINE__,		\
+				(P_DEV)->name ? (P_DEV)->name : "",	\
+				##__VA_ARGS__);		\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'P_DEV' - possible side-effects?
#333: FILE: drivers/net/qede/base/ecore.h:212:
+#define DP_ERR(P_DEV, fmt, ...)				\
+do {							\
+	DP_INT_LOG((P_DEV), ECORE_LEVEL_ERR, 0,		\
+		"ERR: [%s:%d(%s)]" fmt, ##__VA_ARGS__);	\
+	PRINT_ERR((P_DEV)->dp_ctx, "[%s:%d(%s)]" fmt,	\
+		  __func__, __LINE__,			\
+		  (P_DEV)->name ? (P_DEV)->name : "",	\
+		  ##__VA_ARGS__);			\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fmt' - possible side-effects?
#333: FILE: drivers/net/qede/base/ecore.h:212:
+#define DP_ERR(P_DEV, fmt, ...)				\
+do {							\
+	DP_INT_LOG((P_DEV), ECORE_LEVEL_ERR, 0,		\
+		"ERR: [%s:%d(%s)]" fmt, ##__VA_ARGS__);	\
+	PRINT_ERR((P_DEV)->dp_ctx, "[%s:%d(%s)]" fmt,	\
+		  __func__, __LINE__,			\
+		  (P_DEV)->name ? (P_DEV)->name : "",	\
+		  ##__VA_ARGS__);			\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'P_DEV' - possible side-effects?
#343: FILE: drivers/net/qede/base/ecore.h:222:
+#define DP_NOTICE(P_DEV, is_assert, fmt, ...)				\
+do {									\
+	DP_INT_LOG((P_DEV), ECORE_LEVEL_NOTICE,	0,			\
+		 "NOTICE: [%s:%d(%s)]" fmt, ##__VA_ARGS__);		\
+	if (OSAL_UNLIKELY((P_DEV)->dp_level <= ECORE_LEVEL_NOTICE)) {	\
+		PRINT((P_DEV)->dp_ctx, "[%s:%d(%s)]" fmt,		\
+		      __func__, __LINE__,				\
+		      (P_DEV)->name ? (P_DEV)->name : "",		\
+		      ##__VA_ARGS__);					\
+		OSAL_ASSERT(!(is_assert));				\
+	}								\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fmt' - possible side-effects?
#343: FILE: drivers/net/qede/base/ecore.h:222:
+#define DP_NOTICE(P_DEV, is_assert, fmt, ...)				\
+do {									\
+	DP_INT_LOG((P_DEV), ECORE_LEVEL_NOTICE,	0,			\
+		 "NOTICE: [%s:%d(%s)]" fmt, ##__VA_ARGS__);		\
+	if (OSAL_UNLIKELY((P_DEV)->dp_level <= ECORE_LEVEL_NOTICE)) {	\
+		PRINT((P_DEV)->dp_ctx, "[%s:%d(%s)]" fmt,		\
+		      __func__, __LINE__,				\
+		      (P_DEV)->name ? (P_DEV)->name : "",		\
+		      ##__VA_ARGS__);					\
+		OSAL_ASSERT(!(is_assert));				\
+	}								\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'P_DEV' - possible side-effects?
#356: FILE: drivers/net/qede/base/ecore.h:235:
+#define DP_INFO(P_DEV, fmt, ...)				      \
+do {								      \
+	DP_INT_LOG((P_DEV), ECORE_LEVEL_INFO, 0,		      \
+		"INFO: [%s:%d(%s)]" fmt, ##__VA_ARGS__);	      \
+	if (OSAL_UNLIKELY((P_DEV)->dp_level <= ECORE_LEVEL_INFO)) {   \
+		PRINT((P_DEV)->dp_ctx, "[%s:%d(%s)]" fmt,	      \
+		      __func__, __LINE__,			      \
+		      (P_DEV)->name ? (P_DEV)->name : "",	      \
+		      ##__VA_ARGS__);				      \
+	}							      \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fmt' - possible side-effects?
#356: FILE: drivers/net/qede/base/ecore.h:235:
+#define DP_INFO(P_DEV, fmt, ...)				      \
+do {								      \
+	DP_INT_LOG((P_DEV), ECORE_LEVEL_INFO, 0,		      \
+		"INFO: [%s:%d(%s)]" fmt, ##__VA_ARGS__);	      \
+	if (OSAL_UNLIKELY((P_DEV)->dp_level <= ECORE_LEVEL_INFO)) {   \
+		PRINT((P_DEV)->dp_ctx, "[%s:%d(%s)]" fmt,	      \
+		      __func__, __LINE__,			      \
+		      (P_DEV)->name ? (P_DEV)->name : "",	      \
+		      ##__VA_ARGS__);				      \
+	}							      \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'P_DEV' - possible side-effects?
#368: FILE: drivers/net/qede/base/ecore.h:247:
+#define DP_VERBOSE(P_DEV, module, fmt, ...)				\
+do {									\
+	DP_INT_LOG((P_DEV), ECORE_LEVEL_VERBOSE, module,		\
+		"VERBOSE: [%s:%d(%s)]" fmt, ##__VA_ARGS__);		\
+	if (OSAL_UNLIKELY(((P_DEV)->dp_level <= ECORE_LEVEL_VERBOSE) &&	\
+	    ((P_DEV)->dp_module & module))) {				\
+		PRINT((P_DEV)->dp_ctx, "[%s:%d(%s)]" fmt,		\
+		      __func__, __LINE__,				\
+		      (P_DEV)->name ? (P_DEV)->name : "",		\
+		      ##__VA_ARGS__);					\
+	}								\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'module' - possible side-effects?
#368: FILE: drivers/net/qede/base/ecore.h:247:
+#define DP_VERBOSE(P_DEV, module, fmt, ...)				\
+do {									\
+	DP_INT_LOG((P_DEV), ECORE_LEVEL_VERBOSE, module,		\
+		"VERBOSE: [%s:%d(%s)]" fmt, ##__VA_ARGS__);		\
+	if (OSAL_UNLIKELY(((P_DEV)->dp_level <= ECORE_LEVEL_VERBOSE) &&	\
+	    ((P_DEV)->dp_module & module))) {				\
+		PRINT((P_DEV)->dp_ctx, "[%s:%d(%s)]" fmt,		\
+		      __func__, __LINE__,				\
+		      (P_DEV)->name ? (P_DEV)->name : "",		\
+		      ##__VA_ARGS__);					\
+	}								\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fmt' - possible side-effects?
#368: FILE: drivers/net/qede/base/ecore.h:247:
+#define DP_VERBOSE(P_DEV, module, fmt, ...)				\
+do {									\
+	DP_INT_LOG((P_DEV), ECORE_LEVEL_VERBOSE, module,		\
+		"VERBOSE: [%s:%d(%s)]" fmt, ##__VA_ARGS__);		\
+	if (OSAL_UNLIKELY(((P_DEV)->dp_level <= ECORE_LEVEL_VERBOSE) &&	\
+	    ((P_DEV)->dp_module & module))) {				\
+		PRINT((P_DEV)->dp_ctx, "[%s:%d(%s)]" fmt,		\
+		      __func__, __LINE__,				\
+		      (P_DEV)->name ? (P_DEV)->name : "",		\
+		      ##__VA_ARGS__);					\
+	}								\
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#560: FILE: drivers/net/qede/base/ecore.h:566:
+#define ECORE_IS_NVMETCP_PERSONALITY(dev) \
+	((dev)->hw_info.personality == ECORE_PCI_ISCSI && \
+	 (dev)->is_nvmetcp)

WARNING:TYPO_SPELLING: 'DONT' may be misspelled - perhaps 'DON'T'?
#702: FILE: drivers/net/qede/base/ecore.h:782:
+	ECORE_MF_DONT_ADD_VLAN0_TAG,

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#753: FILE: drivers/net/qede/base/ecore.h:838:
+	bool			is_master;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#754: FILE: drivers/net/qede/base/ecore.h:839:
+	u8			master_pf;

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#774: FILE: drivers/net/qede/base/ecore.h:859:
+enum ecore_hsi_def_type {

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#775: FILE: drivers/net/qede/base/ecore.h:860:
+	ECORE_HSI_DEF_MAX_NUM_VFS,

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#776: FILE: drivers/net/qede/base/ecore.h:861:
+	ECORE_HSI_DEF_MAX_NUM_L2_QUEUES,

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#777: FILE: drivers/net/qede/base/ecore.h:862:
+	ECORE_HSI_DEF_MAX_NUM_PORTS,

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#778: FILE: drivers/net/qede/base/ecore.h:863:
+	ECORE_HSI_DEF_MAX_SB_PER_PATH,

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#779: FILE: drivers/net/qede/base/ecore.h:864:
+	ECORE_HSI_DEF_MAX_NUM_PFS,

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#780: FILE: drivers/net/qede/base/ecore.h:865:
+	ECORE_HSI_DEF_MAX_NUM_VPORTS,

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#781: FILE: drivers/net/qede/base/ecore.h:866:
+	ECORE_HSI_DEF_NUM_ETH_RSS_ENGINE,

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#782: FILE: drivers/net/qede/base/ecore.h:867:
+	ECORE_HSI_DEF_MAX_QM_TX_QUEUES,

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#783: FILE: drivers/net/qede/base/ecore.h:868:
+	ECORE_HSI_DEF_NUM_PXP_ILT_RECORDS,

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#784: FILE: drivers/net/qede/base/ecore.h:869:
+	ECORE_HSI_DEF_NUM_RDMA_STATISTIC_COUNTERS,

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#785: FILE: drivers/net/qede/base/ecore.h:870:
+	ECORE_HSI_DEF_MAX_QM_GLOBAL_RLS,

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#786: FILE: drivers/net/qede/base/ecore.h:871:
+	ECORE_HSI_DEF_MAX_PBF_CMD_LINES,

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#787: FILE: drivers/net/qede/base/ecore.h:872:
+	ECORE_HSI_DEF_MAX_BTB_BLOCKS,

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#788: FILE: drivers/net/qede/base/ecore.h:873:
+	ECORE_NUM_HSI_DEFS

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_p_hwfn' - possible side-effects?
#807: FILE: drivers/net/qede/base/ecore.h:891:
+#define IS_AFFIN_HWFN(_p_hwfn) \
+	((_p_hwfn) == ECORE_AFFIN_HWFN((_p_hwfn)->p_dev))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'i == PROTOCOLID_CORE'
#1319: FILE: drivers/net/qede/base/ecore_cxt.c:202:
+		if (ECORE_IS_E5(p_hwfn->p_dev) && (i == PROTOCOLID_CORE))

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#1869: FILE: drivers/net/qede/base/ecore_cxt.c:994:
+#define for_each_ilt_valid_client(pos, clients)	\
+	for (pos = 0; pos < MAX_ILT_CLIENTS; pos++)	\
+		if (!(clients)[pos].active) {	\
+			continue;		\
+		} else				\
 

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pos' - possible side-effects?
#1869: FILE: drivers/net/qede/base/ecore_cxt.c:994:
+#define for_each_ilt_valid_client(pos, clients)	\
+	for (pos = 0; pos < MAX_ILT_CLIENTS; pos++)	\
+		if (!(clients)[pos].active) {	\
+			continue;		\
+		} else				\
 

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ilt_client == ILT_CLI_CDUT'
#1906: FILE: drivers/net/qede/base/ecore_cxt.c:1048:
+	if (ECORE_IS_RDMA_PERSONALITY(p_hwfn) &&
+	    ((ilt_client == ILT_CLI_CDUT) || ilt_client == ILT_CLI_TSDM))

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#1936: FILE: drivers/net/qede/base/ecore_cxt.c:1088:
+			   "ILT shadow: Line [%d] Physical 0x%" PRIx64 " Virtual %p Size %d
",

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'type == PROTOCOLID_CORE'
#2018: FILE: drivers/net/qede/base/ecore_cxt.c:1251:
+		if (ECORE_IS_E5(p_hwfn->p_dev) && (type == PROTOCOLID_CORE))

WARNING:TYPO_SPELLING: 'incase' may be misspelled - perhaps 'in case'?
#2373: FILE: drivers/net/qede/base/ecore_cxt.c:1923:
+			/** virt_addr could be OSAL_NULL incase of dynamic

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p_hwfn->hw_info.personality == ECORE_PCI_FCOE'
#2620: FILE: drivers/net/qede/base/ecore_cxt.c:2154:
+	if ((p_hwfn->hw_info.personality == ECORE_PCI_FCOE) &&
+	    p_hwfn->pf_params.fcoe_pf_params.is_target)

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#3208: FILE: drivers/net/qede/base/ecore_cxt.h:11:
+#include "ecore_hsi_eth.h"

WARNING:TYPO_SPELLING: 'Initailze' may be misspelled - perhaps 'Initialize'?
#3300: FILE: drivers/net/qede/base/ecore_cxt.h:109:
+ * @brief ecore_cxt_hw_init_common - Initailze ILT and DQ, common phase, per path.

WARNING:TYPO_SPELLING: 'protocl' may be misspelled - perhaps 'protocol'?
#3372: FILE: drivers/net/qede/base/ecore_cxt.h:249:
+/* PF per protocl configuration object */

WARNING:TYPO_SPELLING: 'protocl' may be misspelled - perhaps 'protocol'?
#3450: FILE: drivers/net/qede/base/ecore_cxt.h:324:
+	/* Per protocl configuration */

WARNING:TYPO_SPELLING: 'indepent' may be misspelled - perhaps 'independent'?
#3477: FILE: drivers/net/qede/base/ecore_cxt.h:359:
+	 * require memory which is indepent of the general context/task

WARNING:TYPO_SPELLING: 'DONT' may be misspelled - perhaps 'DON'T'?
#3693: FILE: drivers/net/qede/base/ecore_dcbx.c:203:
+	if (OSAL_TEST_BIT(ECORE_MF_DONT_ADD_VLAN0_TAG, &p_hwfn->p_dev->mf_bits))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'type == DCBX_PROTOCOL_ROCE'
#3705: FILE: drivers/net/qede/base/ecore_dcbx.c:211:
+	if (OSAL_TEST_BIT(ECORE_MF_UFP_SPECIFIC, &p_hwfn->p_dev->mf_bits) &&
+	    (type == DCBX_PROTOCOL_ROCE)) {

WARNING:TYPO_SPELLING: 'DONT' may be misspelled - perhaps 'DON'T'?
#5230: FILE: drivers/net/qede/base/ecore_dev.c:1298:
+					ECORE_LLH_DONT_CARE, dest_port);

WARNING:TYPO_SPELLING: 'DONT' may be misspelled - perhaps 'DON'T'?
#5238: FILE: drivers/net/qede/base/ecore_dev.c:1306:
+					src_port, ECORE_LLH_DONT_CARE);

WARNING:TYPO_SPELLING: 'DONT' may be misspelled - perhaps 'DON'T'?
#5311: FILE: drivers/net/qede/base/ecore_dev.c:1446:
+					 ECORE_LLH_DONT_CARE, dest_port);

WARNING:TYPO_SPELLING: 'DONT' may be misspelled - perhaps 'DON'T'?
#5319: FILE: drivers/net/qede/base/ecore_dev.c:1454:
+					 src_port, ECORE_LLH_DONT_CARE);

WARNING:TYPO_SPELLING: 'actualy' may be misspelled - perhaps 'actually'?
#5692: FILE: drivers/net/qede/base/ecore_dev.c:1901:
+#define ACTIVE_TCS_BMAP_E5 0x1f /* 0..3 actualy used, 4 serves OOO */

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#6600: FILE: drivers/net/qede/base/ecore_dev.c:2782:
+		if (lag_info->is_master &&

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#6922: FILE: drivers/net/qede/base/ecore_dev.c:3131:
+static enum _ecore_status_t ecore_lag_create_slave(struct ecore_hwfn *p_hwfn,

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#6923: FILE: drivers/net/qede/base/ecore_dev.c:3132:
+						   u8 master_pfid)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#6926: FILE: drivers/net/qede/base/ecore_dev.c:3135:
+	u8 slave_ppfid = 1; /* TODO: Need some sort of resource management function

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#6934: FILE: drivers/net/qede/base/ecore_dev.c:3143:
+	rc = ecore_llh_map_ppfid_to_pfid(p_hwfn, p_ptt, slave_ppfid,

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#6935: FILE: drivers/net/qede/base/ecore_dev.c:3144:
+					 master_pfid);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#6941: FILE: drivers/net/qede/base/ecore_dev.c:3150:
+	rc = ecore_llh_add_protocol_filter(p_hwfn->p_dev, slave_ppfid,

WARNING:TYPO_SPELLING: 'DONT' may be misspelled - perhaps 'DON'T'?
#6943: FILE: drivers/net/qede/base/ecore_dev.c:3152:
+					   ECORE_LLH_DONT_CARE);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#6948: FILE: drivers/net/qede/base/ecore_dev.c:3157:
+	return ecore_llh_add_protocol_filter(p_hwfn->p_dev, slave_ppfid,

WARNING:TYPO_SPELLING: 'DONT' may be misspelled - perhaps 'DON'T'?
#6950: FILE: drivers/net/qede/base/ecore_dev.c:3159:
+					     ECORE_LLH_DONT_CARE, 4791);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#6953: FILE: drivers/net/qede/base/ecore_dev.c:3162:
+static void ecore_lag_destroy_slave(struct ecore_hwfn *p_hwfn)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#6956: FILE: drivers/net/qede/base/ecore_dev.c:3165:
+	u8 slave_ppfid = 1; /* Need some sort of resource management function

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#6961: FILE: drivers/net/qede/base/ecore_dev.c:3170:
+	ecore_llh_remove_protocol_filter(p_hwfn->p_dev, slave_ppfid,

WARNING:TYPO_SPELLING: 'DONT' may be misspelled - perhaps 'DON'T'?
#6963: FILE: drivers/net/qede/base/ecore_dev.c:3172:
+					 0x8915, ECORE_LLH_DONT_CARE);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#6966: FILE: drivers/net/qede/base/ecore_dev.c:3175:
+	ecore_llh_remove_protocol_filter(p_hwfn->p_dev, slave_ppfid,

WARNING:TYPO_SPELLING: 'DONT' may be misspelled - perhaps 'DON'T'?
#6968: FILE: drivers/net/qede/base/ecore_dev.c:3177:
+					 ECORE_LLH_DONT_CARE, 4791);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#6971: FILE: drivers/net/qede/base/ecore_dev.c:3180:
+		ecore_llh_map_ppfid_to_pfid(p_hwfn, p_ptt, slave_ppfid,

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#6988: FILE: drivers/net/qede/base/ecore_dev.c:3197:
+	if (lag_info->master_pf == 0) {

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#6991: FILE: drivers/net/qede/base/ecore_dev.c:3200:
+	} else if (lag_info->master_pf == 2) {

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#6999: FILE: drivers/net/qede/base/ecore_dev.c:3208:
+static enum _ecore_status_t ecore_lag_create_master(struct ecore_hwfn *p_hwfn)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#7015: FILE: drivers/net/qede/base/ecore_dev.c:3224:
+static enum _ecore_status_t ecore_lag_destroy_master(struct ecore_hwfn *p_hwfn)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#7038: FILE: drivers/net/qede/base/ecore_dev.c:3247:
+	u8 master_pfid = p_hwfn->abs_pf_id < 2 ? 0 : 2;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#7050: FILE: drivers/net/qede/base/ecore_dev.c:3259:
+	p_hwfn->lag_info.is_master = p_hwfn->abs_pf_id == master_pfid;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#7050: FILE: drivers/net/qede/base/ecore_dev.c:3259:
+	p_hwfn->lag_info.is_master = p_hwfn->abs_pf_id == master_pfid;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#7051: FILE: drivers/net/qede/base/ecore_dev.c:3260:
+	p_hwfn->lag_info.master_pf = master_pfid;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#7051: FILE: drivers/net/qede/base/ecore_dev.c:3260:
+	p_hwfn->lag_info.master_pf = master_pfid;

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#7054: FILE: drivers/net/qede/base/ecore_dev.c:3263:
+	if (p_hwfn->lag_info.is_master)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#7055: FILE: drivers/net/qede/base/ecore_dev.c:3264:
+		return ecore_lag_create_master(p_hwfn);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#7057: FILE: drivers/net/qede/base/ecore_dev.c:3266:
+	return ecore_lag_create_slave(p_hwfn, master_pfid);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#7057: FILE: drivers/net/qede/base/ecore_dev.c:3266:
+	return ecore_lag_create_slave(p_hwfn, master_pfid);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#7091: FILE: drivers/net/qede/base/ecore_dev.c:3293:
+		if (lag_info->is_master) {

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#7122: FILE: drivers/net/qede/base/ecore_dev.c:3319:
+	if (!lag_info->is_master) {

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#7123: FILE: drivers/net/qede/base/ecore_dev.c:3320:
+		ecore_lag_destroy_slave(p_hwfn);

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#7127: FILE: drivers/net/qede/base/ecore_dev.c:3324:
+	return ecore_lag_destroy_master(p_hwfn);

WARNING:TYPO_SPELLING: 'Protocl' may be misspelled - perhaps 'Protocol'?
#8245: FILE: drivers/net/qede/base/ecore_dev.c:4765:
+	/* Protocl Configuration  - @@@TBD - should we set 0 otherwise?*/

WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif
#8256: FILE: drivers/net/qede/base/ecore_dev.c:4795:
+	#if 0 /* @DPDK */

WARNING:TYPO_SPELLING: 'offest' may be misspelled - perhaps 'offset'?
#8884: FILE: drivers/net/qede/base/ecore_dev.c:5729:
+	const u32 reg_wake_buffer_offest =

WARNING:TYPO_SPELLING: 'offest' may be misspelled - perhaps 'offset'?
#8916: FILE: drivers/net/qede/base/ecore_dev.c:5761:
+				  reg_wake_buffer_offest + (i * sizeof(u32)));

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'res_id == ECORE_PQ'
#9256: FILE: drivers/net/qede/base/ecore_dev.c:6222:
+	if ((res_id == ECORE_PQ) &&
+	    ((*p_resc_num % 8) || (*p_resc_start % 8))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'res_id == ECORE_VF_RDMA_CNQ_RAM'
#9279: FILE: drivers/net/qede/base/ecore_dev.c:6245:
+	if ((res_id == ECORE_VF_RDMA_CNQ_RAM) &&
+	    (!ECORE_IS_RDMA_PERSONALITY(p_hwfn) ||
+	    !ecore_iov_vf_db_bar_size(p_hwfn, p_hwfn->p_main_ptt)))

WARNING:TYPO_SPELLING: 'DONT' may be misspelled - perhaps 'DON'T'?
#9729: FILE: drivers/net/qede/base/ecore_dev.c:6874:
+					 1 << ECORE_MF_DONT_ADD_VLAN0_TAG;

WARNING:TYPO_SPELLING: 'DONT' may be misspelled - perhaps 'DON'T'?
#9740: FILE: drivers/net/qede/base/ecore_dev.c:6881:
+					 1 << ECORE_MF_DONT_ADD_VLAN0_TAG;

WARNING:TYPO_SPELLING: 'DONT' may be misspelled - perhaps 'DON'T'?
#10941: FILE: drivers/net/qede/base/ecore_dev_api.h:555:
+#define ECORE_LLH_DONT_CARE 0

WARNING:TYPO_SPELLING: 'QUE' may be misspelled - perhaps 'QUEUE'?
#11031: FILE: drivers/net/qede/base/ecore_dev_api.h:795:
+ * user inputs. Currently this affects RDMA_CNQ, PF_L2_QUE and VF_L2_QUE.

WARNING:TYPO_SPELLING: 'QUE' may be misspelled - perhaps 'QUEUE'?
#11031: FILE: drivers/net/qede/base/ecore_dev_api.h:795:
+ * user inputs. Currently this affects RDMA_CNQ, PF_L2_QUE and VF_L2_QUE.

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pq_size' - possible side-effects?
#12360: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:41:
+#define QM_PQ_SIZE_256B(pq_size)		(pq_size ? DIV_ROUND_UP(pq_size, 0x100) - 1 : 0)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pq_id == last_pq'
#13375: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:995:
+		if ((pq_id == last_pq) || (pq_id % QM_STOP_PQ_MASK_WIDTH ==
+					   (QM_STOP_PQ_MASK_WIDTH - 1))) {

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'weight' - possible side-effects?
#13391: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:1018:
+#define NIG_ETS_UP_BOUND(weight, mtu)		(2 * ((weight) > (mtu) ? (weight) : (mtu)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mtu' - possible side-effects?
#13391: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:1018:
+#define NIG_ETS_UP_BOUND(weight, mtu)		(2 * ((weight) > (mtu) ? (weight) : (mtu)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'inc_val' - possible side-effects?
#13401: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:1034:
+#define NIG_RL_MAX_VAL(inc_val, mtu)		(2 * ((inc_val) > (mtu) ? (inc_val) : (mtu)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mtu' - possible side-effects?
#13401: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:1034:
+#define NIG_RL_MAX_VAL(inc_val, mtu)		(2 * ((inc_val) > (mtu) ? (inc_val) : (mtu)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'weight' - possible side-effects?
#13585: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:1216:
+#define PRS_ETS_UP_BOUND(weight, mtu)		(2 * ((weight) > (mtu) ? (weight) : (mtu)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mtu' - possible side-effects?
#13585: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:1216:
+#define PRS_ETS_UP_BOUND(weight, mtu)		(2 * ((weight) > (mtu) ? (weight) : (mtu)))

WARNING:TYPO_SPELLING: 'guranteed' may be misspelled - perhaps 'guaranteed'?
#13674: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:1314:
+		tc_guaranteed_blocks = (u32)DIV_ROUND_UP(req->guranteed_per_tc, BRB_BLOCK_SIZE);

WARNING:TYPO_SPELLING: 'GUARANTIED' may be misspelled - perhaps 'GUARANTEED'?
#13703: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:1340:
+			ecore_wr(p_hwfn, p_ptt, BRB_REG_TC_GUARANTIED_0 + reg_offset,

WARNING:TYPO_SPELLING: 'GUARANTIED' may be misspelled - perhaps 'GUARANTEED'?
#13708: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:1342:
+			ecore_wr(p_hwfn, p_ptt, BRB_REG_MAIN_TC_GUARANTIED_HYST_0 +

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg_val != 0'
#13868: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:1474:
+	if ((reg_val != 0) && (!ECORE_IS_E5(p_hwfn->p_dev))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg_val != 0'
#13920: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:1518:
+	if ((reg_val != 0) && (!ECORE_IS_E5(p_hwfn->p_dev))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'reg_val != 0'
#13993: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:1583:
+	if ((reg_val != 0) && (!ECORE_IS_E5(p_hwfn->p_dev))) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'vf_zone_size_mode != VF_ZONE_SIZE_MODE_DEFAULT'
#14243: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:1843:
+	if ((vf_zone_size_mode != VF_ZONE_SIZE_MODE_DEFAULT) && (stat_cnt_id > MAX_NUM_PFS)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stat_cnt_id > MAX_NUM_PFS'
#14243: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:1843:
+	if ((vf_zone_size_mode != VF_ZONE_SIZE_MODE_DEFAULT) && (stat_cnt_id > MAX_NUM_PFS)) {

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#14449: FILE: drivers/net/qede/base/ecore_init_fw_funcs.c:2050:
+ * RDMA HSI functions

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#14659: FILE: drivers/net/qede/base/ecore_init_fw_funcs.h:11:
+#include "ecore_hsi_func_common.h"

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#14995: FILE: drivers/net/qede/base/ecore_init_fw_funcs.h:278:
+#endif /* UNUSED_HSI_FUNC */

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#15026: FILE: drivers/net/qede/base/ecore_init_fw_funcs.h:294:
+#endif /* UNUSED_HSI_FUNC */

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#16048: FILE: drivers/net/qede/base/ecore_int.c:213:
+#define ECORE_GRC_ATTENTION_MASTER_MASK		(0xf)

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#16119: FILE: drivers/net/qede/base/ecore_int.c:274:
+			GET_FIELD(tmp, ECORE_GRC_ATTENTION_MASTER)),

WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#16174: FILE: drivers/net/qede/base/ecore_int.c:315:
+/* Register PGLUE_B_REG_MASTER_ZLR_ERR_DETAILS */

WARNING:TYPO_SPELLING: 'pedning' may be misspelled - perhaps 'pending'?
#16346: FILE: drivers/net/qede/base/ecore_int.c:472:
+	/* Flush any pedning (e)dpm as they may never arrive.

WARNING:TYPO_SPELLING: 'handeld' may be misspelled - perhaps 'handled'?
#16593: FILE: drivers/net/qede/base/ecore_int.c:691:
+		/* mark interrupt as handeld (note: even if drop was due to a diffrent

WARNING:TYPO_SPELLING: 'diffrent' may be misspelled - perhaps 'different'?
#16593: FILE: drivers/net/qede/base/ecore_int.c:691:
+		/* mark interrupt as handeld (note: even if drop was due to a diffrent

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p_sp_sb->pi_info_arr[pi].comp_cb != OSAL_NULL'
#17570: FILE: drivers/net/qede/base/ecore_int.c:2148:
+		if ((p_sp_sb->pi_info_arr[pi].comp_cb != OSAL_NULL) &&
+		    (p_sp_sb->pi_info_arr[pi].comp_cb != p_hwfn->p_dummy_cb))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p_sp_sb->pi_info_arr[pi].comp_cb != p_hwfn->p_dummy_cb'
#17570: FILE: drivers/net/qede/base/ecore_int.c:2148:
+		if ((p_sp_sb->pi_info_arr[pi].comp_cb != OSAL_NULL) &&
+		    (p_sp_sb->pi_info_arr[pi].comp_cb != p_hwfn->p_dummy_cb))

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#17939: FILE: drivers/net/qede/base/ecore_int_api.h:10:
+#include "common_hsi.h"

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'vfid' - possible side-effects?
#18219: FILE: drivers/net/qede/base/ecore_iov_api.h:18:
+#define ECORE_VF_ARRAY_GET_VFID(arr, vfid)	\
+	(((arr)[(vfid) / 64]) & (1ULL << ((vfid) % 64)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'vfid' - possible side-effects?
#18222: FILE: drivers/net/qede/base/ecore_iov_api.h:21:
+#define ECORE_VF_ARRAY_SET_VFID(arr, vfid)	\
+	(((arr)[(vfid) / 64]) |= (1ULL << ((vfid) % 64)))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'vfid' - possible side-effects?
#18225: FILE: drivers/net/qede/base/ecore_iov_api.h:24:
+#define ECORE_VF_ARRAY_CLEAR_VFID(arr, vfid)	\
+	(((arr)[(vfid) / 64]) &= ~(1ULL << ((vfid) % 64)))

WARNING:TYPO_SPELLING: 'wihtout' may be misspelled - perhaps 'without'?
#18376: FILE: drivers/net/qede/base/ecore_iov_api.h:757:
+ * @brief Set default vlan in VF info wihtout configuring FW/HW.

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p_filter_cmd->opcode != ECORE_FILTER_REMOVE'
#20142: FILE: drivers/net/qede/base/ecore_l2.c:1719:
+	if ((p_filter_cmd->opcode != ECORE_FILTER_ADD  &&
 	     (p_filter_cmd->opcode != ECORE_FILTER_REMOVE)) ||
+	     (p_filter_cmd->num_mc_addrs > ECORE_MAX_MC_ADDRS)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'p_filter_cmd->num_mc_addrs > ECORE_MAX_MC_ADDRS'
#20142: FILE: drivers/net/qede/base/ecore_l2.c:1719:
+	if ((p_filter_cmd->opcode != ECORE_FILTER_ADD  &&
 	     (p_filter_cmd->opcode != ECORE_FILTER_REMOVE)) ||
+	     (p_filter_cmd->num_mc_addrs > ECORE_MAX_MC_ADDRS)) {

WARNING:TYPO_SPELLING: 'iff' may be misspelled - perhaps 'if'?
#20745: FILE: drivers/net/qede/base/ecore_l2_api.h:539:
+	/* true iff this filter is to be added. Else to be removed */

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#21413: FILE: drivers/net/qede/base/ecore_mcp.c:1074:
+	SET_MFW_FIELD(mb_params.param, DRV_ID_MCP_HSI_VER,

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#21414: FILE: drivers/net/qede/base/ecore_mcp.c:1075:
+		      p_in_params->hsi_ver == ECORE_LOAD_REQ_HSI_VER_DEFAULT ?

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#21414: FILE: drivers/net/qede/base/ecore_mcp.c:1075:
+		      p_in_params->hsi_ver == ECORE_LOAD_REQ_HSI_VER_DEFAULT ?

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#21415: FILE: drivers/net/qede/base/ecore_mcp.c:1076:
+		      LOAD_REQ_HSI_VERSION : p_in_params->hsi_ver);

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#21415: FILE: drivers/net/qede/base/ecore_mcp.c:1076:
+		      LOAD_REQ_HSI_VERSION : p_in_params->hsi_ver);

WARNING:TYPO_SPELLING: 'disbale' may be misspelled - perhaps 'disable'?
#21694: FILE: drivers/net/qede/base/ecore_mcp.c:1630:
+			   "Link is down - disbale dcbx
");

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#21956: FILE: drivers/net/qede/base/ecore_mcp.c:1988:
+		hsi_param = DRV_MSG_CODE_STATS_TYPE_FCOE;

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#21960: FILE: drivers/net/qede/base/ecore_mcp.c:1992:
+		hsi_param = DRV_MSG_CODE_STATS_TYPE_ISCSI;

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#21964: FILE: drivers/net/qede/base/ecore_mcp.c:1996:
+		hsi_param = DRV_MSG_CODE_STATS_TYPE_RDMA;

CHECK:CAMELCASE: Avoid CamelCase: <PRId64>
#23958: FILE: drivers/net/qede/base/ecore_mcp.c:4764:
+		   "Number of memory ECC events: %" PRId64 "
", *num_events);

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'params' - possible side-effects?
#24940: FILE: drivers/net/qede/base/ecore_mcp.h:105:
+#define ECORE_MB_FLAGS_IS_SET(params, flag)	\
 	((params) != OSAL_NULL && ((params)->flags & ECORE_MB_FLAG_##flag))

WARNING:TYPO_SPELLING: 'iff' may be misspelled - perhaps 'if'?
#25561: FILE: drivers/net/qede/base/ecore_mcp_api.h:1088:
+ * @return ECORE_SUCCESS iff p_buffer now contains the nvram image.

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#25900: FILE: drivers/net/qede/base/ecore_mng_tlv.c:12:
+#include "ecore_hsi_roce.h"

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#25901: FILE: drivers/net/qede/base/ecore_mng_tlv.c:13:
+#include "ecore_hsi_iwarp.h"

WARNING:TYPO_SPELLING: 'taget' may be misspelled - perhaps 'target'?
#27330: FILE: drivers/net/qede/base/ecore_mng_tlv.c:1158:
+			p_buf->p_val = (u8 *)&p_drv_buf->boot_taget_portal;

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#27581: FILE: drivers/net/qede/base/ecore_proto_if.h:37:
+/* Most of the parameters below are described in the FW FCoE HSI */

WARNING:TYPO_SPELLING: 'QUE' may be misspelled - perhaps 'QUEUE'?
#27683: FILE: drivers/net/qede/base/ecore_proto_if.h:137:
+	 * Allowing an incrementation in ECORE_PF_L2_QUE.

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#29967: FILE: drivers/net/qede/base/ecore_sriov.c:201:
+			   "VF [%d] - Requested fp hsi %02x.%02x which is slightly newer than PF's %02x.%02x; Configuring PFs version
",

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#30972: FILE: drivers/net/qede/base/ecore_sriov.c:2035:
+				"VF[%d] needs fastpath HSI %02x.%02x, which is incompatible with loaded FW's faspath HSI %02x.%02x
",

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#30972: FILE: drivers/net/qede/base/ecore_sriov.c:2035:
+				"VF[%d] needs fastpath HSI %02x.%02x, which is incompatible with loaded FW's faspath HSI %02x.%02x
",

CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#32388: FILE: drivers/net/qede/base/ecore_sriov.c:4920:
+			  "reply address %" PRIu64 "
",

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p_hwfn' - possible side-effects?
#33245: FILE: drivers/net/qede/base/ecore_sriov.h:245:
+#define ECORE_IS_VF_RDMA(p_hwfn)	(((p_hwfn)->pf_iov_info) && \
+					((p_hwfn)->pf_iov_info->rdma_enable))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects?
#33391: FILE: drivers/net/qede/base/ecore_utils.h:46:
+#define __ALIGN_MASK(x, mask)	(((x) + (mask)) & ~(mask))

WARNING:TYPO_SPELLING: 'fullill' may be misspelled - perhaps 'fulfill'?
#33592: FILE: drivers/net/qede/base/ecore_vf.c:268:
+		   "PF unwilling to fullill resource request: rxq [%u/%u] txq [%u/%u] sbs [%u/%u] mac [%u/%u] vlan [%u/%u] mc [%u/%u] cids [%u/%u]. Try PF recommended amount
",

WARNING:TYPO_SPELLING: 'AQUIRE' may be misspelled - perhaps 'ACQUIRE'?
#33683: FILE: drivers/net/qede/base/ecore_vf.c:442:
+				   "VF AQUIRE-RDMA capabilities is:%" PRIx64 "
",

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#33712: FILE: drivers/net/qede/base/ecore_vf.c:471:
+					  "PF uses an incompatible fastpath HSI %02x.%02x [VF requires %02x.%02x]. Please change to a VF driver using %02x.xx.
",

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#33792: FILE: drivers/net/qede/base/ecore_vf.c:564:
+	if (!p_iov->b_pre_fp_hsi &&

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'resp->pfdev_info.minor_fp_hsi < ETH_HSI_VER_MINOR'
#33792: FILE: drivers/net/qede/base/ecore_vf.c:564:
+	if (!p_iov->b_pre_fp_hsi &&
 	    (resp->pfdev_info.minor_fp_hsi < ETH_HSI_VER_MINOR))

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#33797: FILE: drivers/net/qede/base/ecore_vf.c:567:
+			"PF is using older fastpath HSI; %02x.%02x is configured
",

CHECK:BRACES: Unbalanced braces around else statement
#33830: FILE: drivers/net/qede/base/ecore_vf.c:643:
+		else {

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#34780: FILE: drivers/net/qede/base/ecore_vfpf_if.h:10:
+#define T_ETH_INDIRECTION_TABLE_SIZE 128 /* @@@ TBD MichalK this should be HSI? */

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#34818: FILE: drivers/net/qede/base/ecore_vfpf_if.h:104:
+#define VFPF_ACQUIRE_CAP_PRE_FP_HSI	(1 << 0) /* VF pre-FP hsi version */

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#34818: FILE: drivers/net/qede/base/ecore_vfpf_if.h:104:
+#define VFPF_ACQUIRE_CAP_PRE_FP_HSI	(1 << 0) /* VF pre-FP hsi version */

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#35075: FILE: drivers/net/qede/base/eth_common.h:16:
+#define ETH_HSI_VER_MAJOR                   3    /* ETH FP HSI Major version */

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#35075: FILE: drivers/net/qede/base/eth_common.h:16:
+#define ETH_HSI_VER_MAJOR                   3    /* ETH FP HSI Major version */

WARNING:TYPO_SPELLING: 'cant' may be misspelled - perhaps 'can't'?
#35513: FILE: drivers/net/qede/base/eth_common.h:525:
+/* Next segment cant be aggregated due to LLC/SNAP, IP error, IP fragment, IPv4 options, IPv6

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#36046: FILE: drivers/net/qede/base/mcp_public.h:280:
+	/* HSI - Cannot add more stats to this struct. If needed, then need to open new struct */

WARNING:TYPO_SPELLING: 'orginized' may be misspelled - perhaps 'organized'?
#36197: FILE: drivers/net/qede/base/mcp_public.h:392:
+	/* Entries in tc table are orginized that the left most is pri 0, right most is prio 7 */

WARNING:TYPO_SPELLING: 'orginized' may be misspelled - perhaps 'organized'?
#36212: FILE: drivers/net/qede/base/mcp_public.h:400:
+	/* Entries in tc table are orginized that the left most is pri 0, right most is prio 7 */

WARNING:TYPO_SPELLING: 'orginized' may be misspelled - perhaps 'organized'?
#36218: FILE: drivers/net/qede/base/mcp_public.h:402:
+	/* Entries in tc table are orginized that the left most is pri 0, right most is prio 7 */

WARNING:TYPO_SPELLING: 'Celcius' may be misspelled - perhaps ''?
#36458: FILE: drivers/net/qede/base/mcp_public.h:615:
+	/* Temperature in Celcius (-255C / +255C), measured every second. */

WARNING:TYPO_SPELLING: 'entires' may be misspelled - perhaps 'entries'?
#36895: FILE: drivers/net/qede/base/mcp_public.h:1066:
+	/* 9 entires for the C2S PCP map for each inner VLAN PCP + 1 default */

WARNING:TYPO_SPELLING: 'PROTOCL' may be misspelled - perhaps 'PROTOCOL'?
#36953: FILE: drivers/net/qede/base/mcp_public.h:1115:
+	/*RDMA PROTOCL*/

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#37019: FILE: drivers/net/qede/base/mcp_public.h:1173:
+#define DRV_ID_MCP_HSI_VER_CURRENT	(LOAD_REQ_HSI_VERSION << DRV_ID_MCP_HSI_VER_OFFSET)

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#37019: FILE: drivers/net/qede/base/mcp_public.h:1173:
+#define DRV_ID_MCP_HSI_VER_CURRENT	(LOAD_REQ_HSI_VERSION << DRV_ID_MCP_HSI_VER_OFFSET)

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#37019: FILE: drivers/net/qede/base/mcp_public.h:1173:
+#define DRV_ID_MCP_HSI_VER_CURRENT	(LOAD_REQ_HSI_VERSION << DRV_ID_MCP_HSI_VER_OFFSET)

WARNING:TYPO_SPELLING: 'DONT' may be misspelled - perhaps 'DON'T'?
#37484: FILE: drivers/net/qede/base/mcp_public.h:1680:
+/* Params - FORCE - Reinitialize the link regardless of LFA , - DONT_CARE - Don't flap the link if

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#37491: FILE: drivers/net/qede/base/mcp_public.h:1687:
+/* OneView feature driver HSI*/

WARNING:TYPO_SPELLING: 'capablities' may be misspelled - perhaps 'capabilities'?
#37525: FILE: drivers/net/qede/base/mcp_public.h:1721:
+/* get fcoe capablities from driver*/

WARNING:TYPO_SPELLING: 'imediately' may be misspelled - perhaps 'immediately'?
#37694: FILE: drivers/net/qede/base/mcp_public.h:1822:
+/* Driver will not use debug data (GEN_LINK_DUMP, GEN_IDLE_CHK), free Buffer imediately */

WARNING:TYPO_SPELLING: 'imediately' may be misspelled - perhaps 'immediately'?
#37696: FILE: drivers/net/qede/base/mcp_public.h:1824:
+/* Driver will not use debug data (GEN_LINK_DUMP, GEN_IDLE_CHK), free Buffer imediately */

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#38194: FILE: drivers/net/qede/base/mcp_public.h:2214:
+	FW_MSG_CODE_DRV_LOAD_REFUSED_HSI_1		= FW_MSG_CODE(0x1021),

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#38196: FILE: drivers/net/qede/base/mcp_public.h:2216:
+	FW_MSG_CODE_DRV_LOAD_REFUSED_HSI		= FW_MSG_CODE(0x1023),

WARNING:TYPO_SPELLING: 'PRES' may be misspelled - perhaps 'PRESS'?
#38284: FILE: drivers/net/qede/base/mcp_public.h:2292:
+#define FW_MB_PARAM_FEATURE_SUPPORT_LP_PRES_DET                     (1 << 3)

WARNING:TYPO_SPELLING: 'Assigend' may be misspelled - perhaps 'Assigned'?
#38392: FILE: drivers/net/qede/base/mcp_public.h:2411:
+	u32 sup_msgs;	/* Assigend with MFW_DRV_MSG_MAX */

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#40838: FILE: drivers/net/qede/base/nvm_cfg.h:1090:
+	/* For OCP2.0, MFW listens on SMBUS slave address 0x3e, and return

WARNING:TYPO_SPELLING: 'HSI' may be misspelled - perhaps 'HIS'?
#41320: FILE: drivers/net/qede/base/nvm_cfg.h:1330:
+		#define NVM_CFG1_GLOB_TRACE_MODULES_DRV_HSI                     0x4

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#42193: FILE: drivers/net/qede/base/nvm_cfg.h:1816:
+		#define NVM_CFG1_PORT_PORT_TYPE_MODULE_SLAVE                    0x4

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#42439: FILE: drivers/net/qede/base/nvm_cfg.h:1902:
+		#define NVM_CFG1_PORT_MNM_10G_PORT_TYPE_MODULE_SLAVE            0x4

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#42592: FILE: drivers/net/qede/base/nvm_cfg.h:1976:
+		#define NVM_CFG1_PORT_MNM_25G_PORT_TYPE_MODULE_SLAVE            0x4

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#42747: FILE: drivers/net/qede/base/nvm_cfg.h:2050:
+		#define NVM_CFG1_PORT_MNM_40G_PORT_TYPE_MODULE_SLAVE            0x4

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#42897: FILE: drivers/net/qede/base/nvm_cfg.h:2124:
+		#define NVM_CFG1_PORT_MNM_50G_PORT_TYPE_MODULE_SLAVE            0x4

WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#43010: FILE: drivers/net/qede/base/nvm_cfg.h:2198:
+		#define NVM_CFG1_PORT_MNM_100G_PORT_TYPE_MODULE_SLAVE           0x4

WARNING:TYPO_SPELLING: 'theshold' may be misspelled - perhaps 'threshold'?
#43607: FILE: drivers/net/qede/base/nvm_cfg.h:2524:
+	 * temperature theshold to shutdown the chip if sampled more than

total: 1 errors, 146 warnings, 51 checks, 42243 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-02-19 11:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210219101422.19121-5-rmody@marvell.com>
2021-02-19 11:20 ` [dpdk-test-report] |WARNING| pw88012 [PATCH 4/7] net/qede/base: update base driver to 8.62.4.0 checkpatch

automatic DPDK test reports

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/test-report/0 test-report/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 test-report test-report/ https://inbox.dpdk.org/test-report \
		test-report@dpdk.org
	public-inbox-index test-report

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.test-report


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git