From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: [dpdk-test-report] |WARNING| pw89125 [PATCH v2 2/8] common/sfc_efx/base: add API to get VirtQ doorbell offset
Date: Mon, 15 Mar 2021 15:00:09 +0100 (CET) [thread overview]
Message-ID: <20210315140009.2A73A58CD@dpdk.org> (raw)
In-Reply-To: <20210315135823.605774-3-andrew.rybchenko@oktetlabs.ru>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/89125
_coding style issues_
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#93: FILE: drivers/common/sfc_efx/base/efx.h:4488:
+ __out uint32_t *offsetp);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_vq_t *' should also have an identifier name
#106: FILE: drivers/common/sfc_efx/base/efx_impl.h:319:
+ efx_rc_t (*evo_get_doorbell_offset)(efx_virtio_vq_t *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t *' should also have an identifier name
#106: FILE: drivers/common/sfc_efx/base/efx_impl.h:319:
+ efx_rc_t (*evo_get_doorbell_offset)(efx_virtio_vq_t *,
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#130: FILE: drivers/common/sfc_efx/base/efx_virtio.c:220:
+ __out uint32_t *offsetp)
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#136: FILE: drivers/common/sfc_efx/base/efx_virtio.c:226:
+ if ((evvp == NULL) || (offsetp == NULL)) {
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#152: FILE: drivers/common/sfc_efx/base/efx_virtio.c:242:
+ if ((rc = evop->evo_get_doorbell_offset(evvp, offsetp)) != 0)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#152: FILE: drivers/common/sfc_efx/base/efx_virtio.c:242:
+ if ((rc = evop->evo_get_doorbell_offset(evvp, offsetp)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#155: FILE: drivers/common/sfc_efx/base/efx_virtio.c:245:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#164: FILE: drivers/common/sfc_efx/base/efx_virtio.c:254:
+ return (rc);
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#180: FILE: drivers/common/sfc_efx/base/rhead_impl.h:499:
+ __out uint32_t *offsetp);
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#196: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:193:
+ __out uint32_t *offsetp)
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#247: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:244:
+ *offsetp = MCDI_OUT_DWORD(req,
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#250: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:247:
+ *offsetp = MCDI_OUT_DWORD(req,
WARNING:TYPO_SPELLING: 'offsetp' may be misspelled - perhaps 'offset'?
#261: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:258:
+ *offsetp = MCDI_OUT_DWORD(req,
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#283: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:280:
+ return (rc);
total: 4 errors, 11 warnings, 186 lines checked
parent reply other threads:[~2021-03-15 14:00 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210315135823.605774-3-andrew.rybchenko@oktetlabs.ru>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315140009.2A73A58CD@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).