* [dpdk-test-report] |WARNING| pw89129 [PATCH v2 5/8] common/sfc_efx/base: add support to verify virtio features
[not found] <20210315135823.605774-6-andrew.rybchenko@oktetlabs.ru>
@ 2021-03-15 14:01 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-03-15 14:01 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/89129
_coding style issues_
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#99: FILE: drivers/common/sfc_efx/base/efx_impl.h:323:
+ efx_rc_t (*evo_verify_features)(efx_nic_t *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_device_type_t' should also have an identifier name
#99: FILE: drivers/common/sfc_efx/base/efx_impl.h:323:
+ efx_rc_t (*evo_verify_features)(efx_nic_t *,
WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t' should also have an identifier name
#99: FILE: drivers/common/sfc_efx/base/efx_impl.h:323:
+ efx_rc_t (*evo_verify_features)(efx_nic_t *,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#142: FILE: drivers/common/sfc_efx/base/efx_virtio.c:325:
+ if ((rc = evop->evo_verify_features(enp, type, features)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#145: FILE: drivers/common/sfc_efx/base/efx_virtio.c:328:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#154: FILE: drivers/common/sfc_efx/base/efx_virtio.c:337:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#225: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:376:
+ return (rc);
total: 4 errors, 3 warnings, 130 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-15 14:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210315135823.605774-6-andrew.rybchenko@oktetlabs.ru>
2021-03-15 14:01 ` [dpdk-test-report] |WARNING| pw89129 [PATCH v2 5/8] common/sfc_efx/base: add support to verify virtio features checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).