From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8CB6A054F for ; Tue, 16 Mar 2021 09:59:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3D1A2428A0; Tue, 16 Mar 2021 09:59:57 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mails.dpdk.org (Postfix) with ESMTP id 8DD5424288B for ; Tue, 16 Mar 2021 09:59:55 +0100 (CET) Received: by dpdk.org (Postfix, from userid 1017) id 8A5602BE3; Tue, 16 Mar 2021 09:59:55 +0100 (CET) In-Reply-To: <20210316085832.942481-6-andrew.rybchenko@oktetlabs.ru> References: <20210316085832.942481-6-andrew.rybchenko@oktetlabs.ru> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20210316085955.8A5602BE3@dpdk.org> Date: Tue, 16 Mar 2021 09:59:55 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw89200 [PATCH v4 5/8] common/sfc_efx/base: add support to verify virtio features X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/89200 _coding style issues_ WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name #99: FILE: drivers/common/sfc_efx/base/efx_impl.h:323: + efx_rc_t (*evo_verify_features)(efx_nic_t *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_virtio_device_type_t' should also have an identifier name #99: FILE: drivers/common/sfc_efx/base/efx_impl.h:323: + efx_rc_t (*evo_verify_features)(efx_nic_t *, WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t' should also have an identifier name #99: FILE: drivers/common/sfc_efx/base/efx_impl.h:323: + efx_rc_t (*evo_verify_features)(efx_nic_t *, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #142: FILE: drivers/common/sfc_efx/base/efx_virtio.c:325: + if ((rc = evop->evo_verify_features(enp, type, features)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #145: FILE: drivers/common/sfc_efx/base/efx_virtio.c:328: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #154: FILE: drivers/common/sfc_efx/base/efx_virtio.c:337: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #225: FILE: drivers/common/sfc_efx/base/rhead_virtio.c:376: + return (rc); total: 4 errors, 3 warnings, 130 lines checked