* [dpdk-test-report] |WARNING| pw89545 [PATCH v2 6/6] net/ngbe: define registers
[not found] <20210319072628.10000-7-jiawenwu@trustnetic.com>
@ 2021-03-19 7:28 ` checkpatch
2021-03-19 8:55 ` [dpdk-test-report] |SUCCESS| pw89545 " 0-day Robot
2021-03-19 8:57 ` [dpdk-test-report] |SUCCESS| pw89545 [dpdk-dev] [PATCH v2 6/6] " 0-day Robot
2 siblings, 0 replies; 3+ messages in thread
From: checkpatch @ 2021-03-19 7:28 UTC (permalink / raw)
To: test-report; +Cc: Jiawen Wu
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/89545
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side-effects?
#107: FILE: drivers/net/ngbe/base/ngbe_regs.h:35:
+#define ROUND_UP(x, y) (((x) + (y) - 1) / (y) * (y))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side-effects?
#108: FILE: drivers/net/ngbe/base/ngbe_regs.h:36:
+#define ROUND_DOWN(x, y) ((x) / (y) * (y))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#109: FILE: drivers/net/ngbe/base/ngbe_regs.h:37:
+#define ROUND_OVER(x, maxbits, unitbits) \
+ ((x) >= 1 << (maxbits) ? 0 : (x) >> (unitbits))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects?
#840: FILE: drivers/net/ngbe/base/ngbe_regs.h:768:
+#define NGBE_PBTXSTAT_EMPT(tc, r) ((1 << (tc) & (r)) >> (tc))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last' - possible side-effects?
#1355: FILE: drivers/net/ngbe/base/ngbe_regs.h:1283:
+#define NGBE_UPDCNT32(reg, last, cur) \
+do { \
+ uint32_t latest = rd32(hw, reg); \
+ if (hw->offset_loaded || hw->rx_loaded) \
+ last = 0; \
+ cur += (latest - last) & UINT_MAX; \
+ last = latest; \
+} while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cur' may be better as '(cur)' to avoid precedence issues
#1355: FILE: drivers/net/ngbe/base/ngbe_regs.h:1283:
+#define NGBE_UPDCNT32(reg, last, cur) \
+do { \
+ uint32_t latest = rd32(hw, reg); \
+ if (hw->offset_loaded || hw->rx_loaded) \
+ last = 0; \
+ cur += (latest - last) & UINT_MAX; \
+ last = latest; \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'regl' - possible side-effects?
#1364: FILE: drivers/net/ngbe/base/ngbe_regs.h:1292:
+#define NGBE_UPDCNT36(regl, last, cur) \
+do { \
+ uint64_t new_lsb = rd32(hw, regl); \
+ uint64_t new_msb = rd32(hw, regl + 4); \
+ uint64_t latest = ((new_msb << 32) | new_lsb); \
+ if (hw->offset_loaded || hw->rx_loaded) \
+ last = 0; \
+ cur += (0x1000000000LL + latest - last) & 0xFFFFFFFFFLL; \
+ last = latest; \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last' - possible side-effects?
#1364: FILE: drivers/net/ngbe/base/ngbe_regs.h:1292:
+#define NGBE_UPDCNT36(regl, last, cur) \
+do { \
+ uint64_t new_lsb = rd32(hw, regl); \
+ uint64_t new_msb = rd32(hw, regl + 4); \
+ uint64_t latest = ((new_msb << 32) | new_lsb); \
+ if (hw->offset_loaded || hw->rx_loaded) \
+ last = 0; \
+ cur += (0x1000000000LL + latest - last) & 0xFFFFFFFFFLL; \
+ last = latest; \
+} while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'cur' may be better as '(cur)' to avoid precedence issues
#1364: FILE: drivers/net/ngbe/base/ngbe_regs.h:1292:
+#define NGBE_UPDCNT36(regl, last, cur) \
+do { \
+ uint64_t new_lsb = rd32(hw, regl); \
+ uint64_t new_msb = rd32(hw, regl + 4); \
+ uint64_t latest = ((new_msb << 32) | new_lsb); \
+ if (hw->offset_loaded || hw->rx_loaded) \
+ last = 0; \
+ cur += (0x1000000000LL + latest - last) & 0xFFFFFFFFFLL; \
+ last = latest; \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects?
#1515: FILE: drivers/net/ngbe/base/ngbe_regs.h:1443:
+#define rd32w(hw, reg, mask, slice) do { \
+ rd32((hw), reg); \
+ po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg' - possible side-effects?
#1515: FILE: drivers/net/ngbe/base/ngbe_regs.h:1443:
+#define rd32w(hw, reg, mask, slice) do { \
+ rd32((hw), reg); \
+ po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects?
#1515: FILE: drivers/net/ngbe/base/ngbe_regs.h:1443:
+#define rd32w(hw, reg, mask, slice) do { \
+ rd32((hw), reg); \
+ po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects?
#1520: FILE: drivers/net/ngbe/base/ngbe_regs.h:1448:
+#define wr32w(hw, reg, val, mask, slice) do { \
+ wr32((hw), reg, val); \
+ po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg' - possible side-effects?
#1520: FILE: drivers/net/ngbe/base/ngbe_regs.h:1448:
+#define wr32w(hw, reg, val, mask, slice) do { \
+ wr32((hw), reg, val); \
+ po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects?
#1520: FILE: drivers/net/ngbe/base/ngbe_regs.h:1448:
+#define wr32w(hw, reg, val, mask, slice) do { \
+ wr32((hw), reg, val); \
+ po32m((hw), reg, mask, mask, NULL, 5, slice); \
+} while (0)
total: 0 errors, 0 warnings, 15 checks, 1495 lines checked
^ permalink raw reply [flat|nested] 3+ messages in thread