From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8D41CA0A0A
	for <public@inbox.dpdk.org>; Wed, 24 Mar 2021 01:52:16 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8888840693;
	Wed, 24 Mar 2021 01:52:16 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.14.124])
 by mails.dpdk.org (Postfix) with ESMTP id E22BC40684
 for <test-report@dpdk.org>; Wed, 24 Mar 2021 01:52:14 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 1017)
 id DFD071D9E; Wed, 24 Mar 2021 01:52:14 +0100 (CET)
In-Reply-To: <20210324005008.24705-4-dmitry.kozliuk@gmail.com>
References: <20210324005008.24705-4-dmitry.kozliuk@gmail.com>
To: test-report@dpdk.org
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Message-Id: <20210324005214.DFD071D9E@dpdk.org>
Date: Wed, 24 Mar 2021 01:52:14 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw89721 [PATCH v3 3/3] net/pcap: build
 on Windows
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/89721

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <StringCbPrintfW>
#240: FILE: drivers/net/pcap/pcap_osdep_windows.c:48:
+		StringCbPrintfW(adapter_name, sizeof(adapter_name),

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#241: FILE: drivers/net/pcap/pcap_osdep_windows.c:49:
+			L"\DEVICE\TCPIP_%S", guid);

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#244: FILE: drivers/net/pcap/pcap_osdep_windows.c:52:
+			L"%S", device_name);

CHECK:CAMELCASE: Avoid CamelCase: <GetAdapterIndex>
#246: FILE: drivers/net/pcap/pcap_osdep_windows.c:54:
+	ret = GetAdapterIndex(adapter_name, &index);

CHECK:CAMELCASE: Avoid CamelCase: <GetAdaptersAddresses>
#268: FILE: drivers/net/pcap/pcap_osdep_windows.c:76:
+	sys_ret = GetAdaptersAddresses(AF_UNSPEC, 0, NULL, NULL, &size);

CHECK:CAMELCASE: Avoid CamelCase: <Next>
#292: FILE: drivers/net/pcap/pcap_osdep_windows.c:100:
+	for (cur = info; cur != NULL; cur = cur->Next) {

CHECK:CAMELCASE: Avoid CamelCase: <AdapterName>
#293: FILE: drivers/net/pcap/pcap_osdep_windows.c:101:
+		if (strcmp(cur->AdapterName, adapter_name) == 0) {

CHECK:CAMELCASE: Avoid CamelCase: <PhysicalAddressLength>
#294: FILE: drivers/net/pcap/pcap_osdep_windows.c:102:
+			if (cur->PhysicalAddressLength != RTE_ETHER_ADDR_LEN) {

CHECK:CAMELCASE: Avoid CamelCase: <PhysicalAddress>
#301: FILE: drivers/net/pcap/pcap_osdep_windows.c:109:
+			memcpy(mac->addr_bytes, cur->PhysicalAddress,

total: 0 errors, 0 warnings, 9 checks, 181 lines checked