automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Min Hu (Connor)" <humin29@huawei.com>
Subject: [dpdk-test-report] |WARNING| pw91545 [PATCH] net/bonding: fix add bonded device itself as its slave
Date: Thu, 15 Apr 2021 09:10:43 +0200 (CEST)	[thread overview]
Message-ID: <20210415071043.C60471209EC@dpdk.org> (raw)
In-Reply-To: <1618470594-64612-1-git-send-email-humin29@huawei.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/91545

_coding style issues_


WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#52: 
Adding the bond device as its own slave should be forbidden. This

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#59: 
testpmd> add bonding slave 4 4

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#70: 
0x000000000052730c in cmd_add_bonding_slave_parsed ()

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#98: FILE: drivers/net/bonding/eth_bond_private.h:215:
+valid_slave_port_id(struct bond_dev_private *internals, uint16_t port_id);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#111: FILE: drivers/net/bonding/rte_eth_bond_api.c:59:
+valid_slave_port_id(struct bond_dev_private *internals, uint16_t slave_port_id)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#111: FILE: drivers/net/bonding/rte_eth_bond_api.c:59:
+valid_slave_port_id(struct bond_dev_private *internals, uint16_t slave_port_id)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#114: FILE: drivers/net/bonding/rte_eth_bond_api.c:61:
+	RTE_ETH_VALID_PORTID_OR_ERR_RET(slave_port_id, -1);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#119: FILE: drivers/net/bonding/rte_eth_bond_api.c:63:
+	/* Verify that slave_port_id refers to a non bonded port */

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#120: FILE: drivers/net/bonding/rte_eth_bond_api.c:64:
+	if (check_for_bonded_ethdev(&rte_eth_devices[slave_port_id]) == 0 &&

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#128: FILE: drivers/net/bonding/rte_eth_bond_api.c:72:
+	if (internals->port_id == slave_port_id) {

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#130: FILE: drivers/net/bonding/rte_eth_bond_api.c:74:
+			"Cannot add the bonded device itself as its slave.");

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#142: FILE: drivers/net/bonding/rte_eth_bond_api.c:465:
+	if (valid_slave_port_id(internals, slave_port_id) != 0)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#142: FILE: drivers/net/bonding/rte_eth_bond_api.c:465:
+	if (valid_slave_port_id(internals, slave_port_id) != 0)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#157: FILE: drivers/net/bonding/rte_eth_bond_api.c:620:
+	if (valid_slave_port_id(internals, slave_port_id) != 0)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#157: FILE: drivers/net/bonding/rte_eth_bond_api.c:620:
+	if (valid_slave_port_id(internals, slave_port_id) != 0)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#168: FILE: drivers/net/bonding/rte_eth_bond_api.c:646:
+	if (valid_slave_port_id(internals, slave_port_id) < 0)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#168: FILE: drivers/net/bonding/rte_eth_bond_api.c:646:
+	if (valid_slave_port_id(internals, slave_port_id) < 0)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#177: FILE: drivers/net/bonding/rte_eth_bond_api.c:794:
+	if (valid_slave_port_id(internals, slave_port_id) != 0)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#177: FILE: drivers/net/bonding/rte_eth_bond_api.c:794:
+	if (valid_slave_port_id(internals, slave_port_id) != 0)

total: 0 errors, 19 warnings, 0 checks, 78 lines checked

       reply	other threads:[~2021-04-15  7:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1618470594-64612-1-git-send-email-humin29@huawei.com>
2021-04-15  7:10 ` checkpatch [this message]
2021-04-15  8:55 ` [dpdk-test-report] |SUCCESS| pw91545 " 0-day Robot
2021-04-15  8:57 ` [dpdk-test-report] |SUCCESS| pw91545 [dpdk-dev] [PATCH] " 0-day Robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210415071043.C60471209EC@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=humin29@huawei.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).