automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: [dpdk-test-report] |WARNING| pw91612 [PATCH v4 3/3] net/pcap: build on Windows
Date: Fri, 16 Apr 2021 00:11:33 +0200 (CEST)	[thread overview]
Message-ID: <20210415221133.B3666120E37@dpdk.org> (raw)
In-Reply-To: <20210415221055.1575-4-dmitry.kozliuk@gmail.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/91612

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <StringCbPrintfW>
#256: FILE: drivers/net/pcap/pcap_osdep_windows.c:48:
+		StringCbPrintfW(adapter_name, sizeof(adapter_name),

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#257: FILE: drivers/net/pcap/pcap_osdep_windows.c:49:
+			L"\DEVICE\TCPIP_%S", guid);

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#260: FILE: drivers/net/pcap/pcap_osdep_windows.c:52:
+			L"%S", device_name);

CHECK:CAMELCASE: Avoid CamelCase: <GetAdapterIndex>
#262: FILE: drivers/net/pcap/pcap_osdep_windows.c:54:
+	ret = GetAdapterIndex(adapter_name, &index);

CHECK:CAMELCASE: Avoid CamelCase: <GetAdaptersAddresses>
#284: FILE: drivers/net/pcap/pcap_osdep_windows.c:76:
+	sys_ret = GetAdaptersAddresses(AF_UNSPEC, 0, NULL, NULL, &size);

CHECK:CAMELCASE: Avoid CamelCase: <Next>
#308: FILE: drivers/net/pcap/pcap_osdep_windows.c:100:
+	for (cur = info; cur != NULL; cur = cur->Next) {

CHECK:CAMELCASE: Avoid CamelCase: <AdapterName>
#309: FILE: drivers/net/pcap/pcap_osdep_windows.c:101:
+		if (strcmp(cur->AdapterName, adapter_name) == 0) {

CHECK:CAMELCASE: Avoid CamelCase: <PhysicalAddressLength>
#310: FILE: drivers/net/pcap/pcap_osdep_windows.c:102:
+			if (cur->PhysicalAddressLength != RTE_ETHER_ADDR_LEN) {

CHECK:CAMELCASE: Avoid CamelCase: <PhysicalAddress>
#317: FILE: drivers/net/pcap/pcap_osdep_windows.c:109:
+			memcpy(mac->addr_bytes, cur->PhysicalAddress,

total: 0 errors, 0 warnings, 9 checks, 195 lines checked

       reply	other threads:[~2021-04-15 22:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210415221055.1575-4-dmitry.kozliuk@gmail.com>
2021-04-15 22:11 ` checkpatch [this message]
2021-04-15 23:55 ` [dpdk-test-report] |SUCCESS| pw91612 " 0-day Robot
2021-04-15 23:56 ` [dpdk-test-report] |SUCCESS| pw91612 [dpdk-dev] [PATCH v4 3/3] " 0-day Robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210415221133.B3666120E37@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).