automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw92375 [PATCH v2 3/4] net/mlx5: support integrity flow item
       [not found] <20210429061634.3481-4-getelson@nvidia.com>
@ 2021-04-29  6:18 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-04-29  6:18 UTC (permalink / raw)
  To: test-report; +Cc: Gregory Etelson

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/92375

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse '_s' - possible side-effects?
#212: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+	(_prt) = ((const struct _s *)(_itm)->mask)->_m;       \
+	(_prt) &= ((const struct _s *)(_itm)->spec)->_m;      \
+	(_prt) = rte_be_to_cpu_16((_prt));                    \
+} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_s' may be better as '(_s)' to avoid precedence issues
#212: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+	(_prt) = ((const struct _s *)(_itm)->mask)->_m;       \
+	(_prt) &= ((const struct _s *)(_itm)->spec)->_m;      \
+	(_prt) = rte_be_to_cpu_16((_prt));                    \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_m' - possible side-effects?
#212: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+	(_prt) = ((const struct _s *)(_itm)->mask)->_m;       \
+	(_prt) &= ((const struct _s *)(_itm)->spec)->_m;      \
+	(_prt) = rte_be_to_cpu_16((_prt));                    \
+} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_m' may be better as '(_m)' to avoid precedence issues
#212: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+	(_prt) = ((const struct _s *)(_itm)->mask)->_m;       \
+	(_prt) &= ((const struct _s *)(_itm)->spec)->_m;      \
+	(_prt) = rte_be_to_cpu_16((_prt));                    \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_itm' - possible side-effects?
#212: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+	(_prt) = ((const struct _s *)(_itm)->mask)->_m;       \
+	(_prt) &= ((const struct _s *)(_itm)->spec)->_m;      \
+	(_prt) = rte_be_to_cpu_16((_prt));                    \
+} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_prt' - possible side-effects?
#212: FILE: drivers/net/mlx5/mlx5_flow.h:1024:
+#define MLX5_ETHER_TYPE_FROM_HEADER(_s, _m, _itm, _prt) do { \
+	(_prt) = ((const struct _s *)(_itm)->mask)->_m;       \
+	(_prt) &= ((const struct _s *)(_itm)->spec)->_m;      \
+	(_prt) = rte_be_to_cpu_16((_prt));                    \
+} while (0)

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#228: FILE: drivers/net/mlx5/mlx5_flow.h:1305:
+	for (; item->type != RTE_FLOW_ITEM_TYPE_END; item++);

total: 1 errors, 0 warnings, 6 checks, 369 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-04-29  6:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210429061634.3481-4-getelson@nvidia.com>
2021-04-29  6:18 ` [dpdk-test-report] |WARNING| pw92375 [PATCH v2 3/4] net/mlx5: support integrity flow item checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).