From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F811A0546 for ; Fri, 30 Apr 2021 15:00:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B9324014F; Fri, 30 Apr 2021 15:00:25 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id B418D4013F for ; Fri, 30 Apr 2021 15:00:22 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id AFB1D121159; Fri, 30 Apr 2021 15:00:22 +0200 (CEST) In-Reply-To: <20210430125725.28796-12-mk@semihalf.com> References: <20210430125725.28796-12-mk@semihalf.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Michal Krawczyk Message-Id: <20210430130022.AFB1D121159@dpdk.org> Date: Fri, 30 Apr 2021 15:00:22 +0200 (CEST) Subject: [dpdk-test-report] |WARNING| pw92500 [PATCH 11/22] net/ena/base: adjust changes to lastest ena-com X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/92500 _coding style issues_ WARNING:TYPO_SPELLING: 'lastest' may be misspelled - perhaps 'latest'? #65: Subject: [dpdk-dev] [PATCH 11/22] net/ena/base: adjust changes to lastest CHECK:CAMELCASE: Avoid CamelCase: #111: FILE: drivers/net/ena/base/ena_plat_dpdk.h:42: +#define ENA_PRIu64 PRIu64 CHECK:CAMELCASE: Avoid CamelCase: #111: FILE: drivers/net/ena/base/ena_plat_dpdk.h:42: +#define ENA_PRIu64 PRIu64 WARNING:SPACE_BEFORE_TAB: please, no space before tabs #129: FILE: drivers/net/ena/base/ena_plat_dpdk.h:97: +#define GENMASK_ULL(h, l) (((~0ULL) - (1ULL << (l)) + 1) & ^I^I \$ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #134: FILE: drivers/net/ena/base/ena_plat_dpdk.h:101: +#define ena_trc_log(dev, level, fmt, arg...) \ ( WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations #139: FILE: drivers/net/ena/base/ena_plat_dpdk.h:103: + ENA_TOUCH(dev), \ CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'spinlock' may be better as '(spinlock)' to avoid precedence issues #169: FILE: drivers/net/ena/base/ena_plat_dpdk.h:131: +#define ENA_SPINLOCK_LOCK(spinlock, flags) \ ({(void)flags; rte_spinlock_lock(&spinlock); }) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'waitqueue' - possible side-effects? #192: FILE: drivers/net/ena/base/ena_plat_dpdk.h:145: +#define ENA_WAIT_EVENT_INIT(waitqueue) \ + do { \ + pthread_mutex_init(&(waitqueue).mutex, NULL); \ + pthread_cond_init(&(waitqueue).cond, NULL); \ } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'waitevent' - possible side-effects? #211: FILE: drivers/net/ena/base/ena_plat_dpdk.h:151: +#define ENA_WAIT_EVENT_WAIT(waitevent, timeout) \ + do { \ + struct timespec wait; \ + struct timeval now; \ + unsigned long timeout_us; \ + gettimeofday(&now, NULL); \ + wait.tv_sec = now.tv_sec + timeout / 1000000UL; \ + timeout_us = timeout % 1000000UL; \ + wait.tv_nsec = (now.tv_usec + timeout_us) * 1000UL; \ + pthread_mutex_lock(&waitevent.mutex); \ + pthread_cond_timedwait(&waitevent.cond, \ + &waitevent.mutex, &wait); \ + pthread_mutex_unlock(&waitevent.mutex); \ } while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'waitevent' may be better as '(waitevent)' to avoid precedence issues #211: FILE: drivers/net/ena/base/ena_plat_dpdk.h:151: +#define ENA_WAIT_EVENT_WAIT(waitevent, timeout) \ + do { \ + struct timespec wait; \ + struct timeval now; \ + unsigned long timeout_us; \ + gettimeofday(&now, NULL); \ + wait.tv_sec = now.tv_sec + timeout / 1000000UL; \ + timeout_us = timeout % 1000000UL; \ + wait.tv_nsec = (now.tv_usec + timeout_us) * 1000UL; \ + pthread_mutex_lock(&waitevent.mutex); \ + pthread_cond_timedwait(&waitevent.cond, \ + &waitevent.mutex, &wait); \ + pthread_mutex_unlock(&waitevent.mutex); \ } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'timeout' - possible side-effects? #211: FILE: drivers/net/ena/base/ena_plat_dpdk.h:151: +#define ENA_WAIT_EVENT_WAIT(waitevent, timeout) \ + do { \ + struct timespec wait; \ + struct timeval now; \ + unsigned long timeout_us; \ + gettimeofday(&now, NULL); \ + wait.tv_sec = now.tv_sec + timeout / 1000000UL; \ + timeout_us = timeout % 1000000UL; \ + wait.tv_nsec = (now.tv_usec + timeout_us) * 1000UL; \ + pthread_mutex_lock(&waitevent.mutex); \ + pthread_cond_timedwait(&waitevent.cond, \ + &waitevent.mutex, &wait); \ + pthread_mutex_unlock(&waitevent.mutex); \ } while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'timeout' may be better as '(timeout)' to avoid precedence issues #211: FILE: drivers/net/ena/base/ena_plat_dpdk.h:151: +#define ENA_WAIT_EVENT_WAIT(waitevent, timeout) \ + do { \ + struct timespec wait; \ + struct timeval now; \ + unsigned long timeout_us; \ + gettimeofday(&now, NULL); \ + wait.tv_sec = now.tv_sec + timeout / 1000000UL; \ + timeout_us = timeout % 1000000UL; \ + wait.tv_nsec = (now.tv_usec + timeout_us) * 1000UL; \ + pthread_mutex_lock(&waitevent.mutex); \ + pthread_cond_timedwait(&waitevent.cond, \ + &waitevent.mutex, &wait); \ + pthread_mutex_unlock(&waitevent.mutex); \ } while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'timeout_us' may be better as '(timeout_us)' to avoid precedence issues #233: FILE: drivers/net/ena/base/ena_plat_dpdk.h:175: +#define ENA_GET_SYSTEM_TIMEOUT(timeout_us) \ + (timeout_us * rte_get_timer_hz() / 1000000 + rte_get_timer_cycles()) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'size' - possible side-effects? #268: FILE: drivers/net/ena/base/ena_plat_dpdk.h:184: +#define ENA_MEM_ALLOC_COHERENT_ALIGNED( \ + dmadev, size, virt, phys, mem_handle, alignment) \ + do { \ + const struct rte_memzone *mz = NULL; \ + ENA_TOUCH(dmadev); \ + if (size > 0) { \ + char z_name[RTE_MEMZONE_NAMESIZE]; \ + snprintf(z_name, sizeof(z_name), "ena_alloc_%"PRIi64"",\ + rte_atomic64_add_return(&ena_alloc_cnt, 1)); \ + mz = rte_memzone_reserve_aligned(z_name, size, \ + SOCKET_ID_ANY, RTE_MEMZONE_IOVA_CONTIG,\ + alignment); \ + mem_handle = mz; \ + } \ + if (mz == NULL) { \ + virt = NULL; \ + phys = 0; \ + } else { \ + memset(mz->addr, 0, size); \ + virt = mz->addr; \ + phys = mz->iova; \ + } \ } while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues #268: FILE: drivers/net/ena/base/ena_plat_dpdk.h:184: +#define ENA_MEM_ALLOC_COHERENT_ALIGNED( \ + dmadev, size, virt, phys, mem_handle, alignment) \ + do { \ + const struct rte_memzone *mz = NULL; \ + ENA_TOUCH(dmadev); \ + if (size > 0) { \ + char z_name[RTE_MEMZONE_NAMESIZE]; \ + snprintf(z_name, sizeof(z_name), "ena_alloc_%"PRIi64"",\ + rte_atomic64_add_return(&ena_alloc_cnt, 1)); \ + mz = rte_memzone_reserve_aligned(z_name, size, \ + SOCKET_ID_ANY, RTE_MEMZONE_IOVA_CONTIG,\ + alignment); \ + mem_handle = mz; \ + } \ + if (mz == NULL) { \ + virt = NULL; \ + phys = 0; \ + } else { \ + memset(mz->addr, 0, size); \ + virt = mz->addr; \ + phys = mz->iova; \ + } \ } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'virt' - possible side-effects? #268: FILE: drivers/net/ena/base/ena_plat_dpdk.h:184: +#define ENA_MEM_ALLOC_COHERENT_ALIGNED( \ + dmadev, size, virt, phys, mem_handle, alignment) \ + do { \ + const struct rte_memzone *mz = NULL; \ + ENA_TOUCH(dmadev); \ + if (size > 0) { \ + char z_name[RTE_MEMZONE_NAMESIZE]; \ + snprintf(z_name, sizeof(z_name), "ena_alloc_%"PRIi64"",\ + rte_atomic64_add_return(&ena_alloc_cnt, 1)); \ + mz = rte_memzone_reserve_aligned(z_name, size, \ + SOCKET_ID_ANY, RTE_MEMZONE_IOVA_CONTIG,\ + alignment); \ + mem_handle = mz; \ + } \ + if (mz == NULL) { \ + virt = NULL; \ + phys = 0; \ + } else { \ + memset(mz->addr, 0, size); \ + virt = mz->addr; \ + phys = mz->iova; \ + } \ } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'phys' - possible side-effects? #268: FILE: drivers/net/ena/base/ena_plat_dpdk.h:184: +#define ENA_MEM_ALLOC_COHERENT_ALIGNED( \ + dmadev, size, virt, phys, mem_handle, alignment) \ + do { \ + const struct rte_memzone *mz = NULL; \ + ENA_TOUCH(dmadev); \ + if (size > 0) { \ + char z_name[RTE_MEMZONE_NAMESIZE]; \ + snprintf(z_name, sizeof(z_name), "ena_alloc_%"PRIi64"",\ + rte_atomic64_add_return(&ena_alloc_cnt, 1)); \ + mz = rte_memzone_reserve_aligned(z_name, size, \ + SOCKET_ID_ANY, RTE_MEMZONE_IOVA_CONTIG,\ + alignment); \ + mem_handle = mz; \ + } \ + if (mz == NULL) { \ + virt = NULL; \ + phys = 0; \ + } else { \ + memset(mz->addr, 0, size); \ + virt = mz->addr; \ + phys = mz->iova; \ + } \ } while (0) CHECK:CAMELCASE: Avoid CamelCase: #275: FILE: drivers/net/ena/base/ena_plat_dpdk.h:191: + snprintf(z_name, sizeof(z_name), "ena_alloc_%"PRIi64"",\ CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #275: FILE: drivers/net/ena/base/ena_plat_dpdk.h:191: + snprintf(z_name, sizeof(z_name), "ena_alloc_%"PRIi64"",\ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #329: FILE: drivers/net/ena/base/ena_plat_dpdk.h:210: +#define ENA_MEM_FREE_COHERENT(dmadev, size, virt, phys, mem_handle) ^I \$ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'size' - possible side-effects? #333: FILE: drivers/net/ena/base/ena_plat_dpdk.h:214: +#define ENA_MEM_ALLOC_COHERENT_NODE_ALIGNED( \ + dmadev, size, virt, phys, mem_handle, node, dev_node, alignment) \ + do { \ + const struct rte_memzone *mz = NULL; \ + ENA_TOUCH(dmadev); ENA_TOUCH(dev_node); \ + if (size > 0) { \ + char z_name[RTE_MEMZONE_NAMESIZE]; \ + snprintf(z_name, sizeof(z_name), "ena_alloc_%"PRIi64"",\ + rte_atomic64_add_return(&ena_alloc_cnt, 1)); \ + mz = rte_memzone_reserve_aligned(z_name, size, \ + node, RTE_MEMZONE_IOVA_CONTIG, alignment); \ + mem_handle = mz; \ + } \ + if (mz == NULL) { \ + virt = NULL; \ + phys = 0; \ + } else { \ + memset(mz->addr, 0, size); \ + virt = mz->addr; \ + phys = mz->iova; \ + } \ } while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues #333: FILE: drivers/net/ena/base/ena_plat_dpdk.h:214: +#define ENA_MEM_ALLOC_COHERENT_NODE_ALIGNED( \ + dmadev, size, virt, phys, mem_handle, node, dev_node, alignment) \ + do { \ + const struct rte_memzone *mz = NULL; \ + ENA_TOUCH(dmadev); ENA_TOUCH(dev_node); \ + if (size > 0) { \ + char z_name[RTE_MEMZONE_NAMESIZE]; \ + snprintf(z_name, sizeof(z_name), "ena_alloc_%"PRIi64"",\ + rte_atomic64_add_return(&ena_alloc_cnt, 1)); \ + mz = rte_memzone_reserve_aligned(z_name, size, \ + node, RTE_MEMZONE_IOVA_CONTIG, alignment); \ + mem_handle = mz; \ + } \ + if (mz == NULL) { \ + virt = NULL; \ + phys = 0; \ + } else { \ + memset(mz->addr, 0, size); \ + virt = mz->addr; \ + phys = mz->iova; \ + } \ } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'virt' - possible side-effects? #333: FILE: drivers/net/ena/base/ena_plat_dpdk.h:214: +#define ENA_MEM_ALLOC_COHERENT_NODE_ALIGNED( \ + dmadev, size, virt, phys, mem_handle, node, dev_node, alignment) \ + do { \ + const struct rte_memzone *mz = NULL; \ + ENA_TOUCH(dmadev); ENA_TOUCH(dev_node); \ + if (size > 0) { \ + char z_name[RTE_MEMZONE_NAMESIZE]; \ + snprintf(z_name, sizeof(z_name), "ena_alloc_%"PRIi64"",\ + rte_atomic64_add_return(&ena_alloc_cnt, 1)); \ + mz = rte_memzone_reserve_aligned(z_name, size, \ + node, RTE_MEMZONE_IOVA_CONTIG, alignment); \ + mem_handle = mz; \ + } \ + if (mz == NULL) { \ + virt = NULL; \ + phys = 0; \ + } else { \ + memset(mz->addr, 0, size); \ + virt = mz->addr; \ + phys = mz->iova; \ + } \ } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'phys' - possible side-effects? #333: FILE: drivers/net/ena/base/ena_plat_dpdk.h:214: +#define ENA_MEM_ALLOC_COHERENT_NODE_ALIGNED( \ + dmadev, size, virt, phys, mem_handle, node, dev_node, alignment) \ + do { \ + const struct rte_memzone *mz = NULL; \ + ENA_TOUCH(dmadev); ENA_TOUCH(dev_node); \ + if (size > 0) { \ + char z_name[RTE_MEMZONE_NAMESIZE]; \ + snprintf(z_name, sizeof(z_name), "ena_alloc_%"PRIi64"",\ + rte_atomic64_add_return(&ena_alloc_cnt, 1)); \ + mz = rte_memzone_reserve_aligned(z_name, size, \ + node, RTE_MEMZONE_IOVA_CONTIG, alignment); \ + mem_handle = mz; \ + } \ + if (mz == NULL) { \ + virt = NULL; \ + phys = 0; \ + } else { \ + memset(mz->addr, 0, size); \ + virt = mz->addr; \ + phys = mz->iova; \ + } \ } while (0) CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #340: FILE: drivers/net/ena/base/ena_plat_dpdk.h:221: + snprintf(z_name, sizeof(z_name), "ena_alloc_%"PRIi64"",\ CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'timeout_us' may be better as '(timeout_us)' to avoid precedence issues #403: FILE: drivers/net/ena/base/ena_plat_dpdk.h:282: +#define ENA_GET_SYSTEM_TIMEOUT(timeout_us) \ (timeout_us * rte_get_timer_hz() / 1000000 + rte_get_timer_cycles()) total: 1 errors, 4 warnings, 21 checks, 336 lines checked