From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Kathleen Capella <kathleen.capella@arm.com>
Subject: [dpdk-test-report] |WARNING| pw92584 [RFC 1/1] app/testpmd: add l3fwd mode to testpmd
Date: Fri, 30 Apr 2021 23:39:46 +0200 (CEST) [thread overview]
Message-ID: <20210430213946.B00D9121159@dpdk.org> (raw)
In-Reply-To: <20210430213747.41530-2-kathleen.capella@arm.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/92584
_coding style issues_
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#368: FILE: app/test-pmd/l3fwd.c:189:
+ unsigned i;
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#481: FILE: app/test-pmd/l3fwd.c:302:
+ * TX burst queue drain
+ */
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#497: FILE: app/test-pmd/l3fwd.c:318:
+ /*
+ * Receive a burst of packets and forward them.
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#525: FILE: app/test-pmd/l3fwd.c:346:
+ /* TODO check l3fwd_poll_resource_setup to see what must be done on
+ a port level, esp init ports_eth_addr[] */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#525: FILE: app/test-pmd/l3fwd.c:346:
+ a port level, esp init ports_eth_addr[] */
WARNING:TYPO_SPELLING: 'destionation' may be misspelled - perhaps 'destination'?
#744: FILE: app/test-pmd/l3fwd_common.h:54:
+ * We group consecutive packets with the same destionation port into one burst.
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#905: FILE: app/test-pmd/l3fwd_common.h:215:
+ while (j < n) {
+ case 0:
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 16)
#935: FILE: app/test-pmd/l3fwd_common.h:245:
+ while (j < len) {
+ case 0:
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#1003: FILE: app/test-pmd/l3fwd_lpm.h:39:
+ /* if (dst_port >= RTE_MAX_ETHPORTS ||
+ (enabled_port_mask & 1 << dst_port) == 0)
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#1030: FILE: app/test-pmd/l3fwd_lpm.h:66:
+ /*TODO check if port is enabled
+ if (dst_port >= RTE_MAX_ETHPORTS ||
WARNING:TYPO_SPELLING: 'destionation' may be misspelled - perhaps 'destination'?
#1319: FILE: app/test-pmd/l3fwd_neon.h:67:
+ * Suppose we have array of destionation ports:
total: 0 errors, 11 warnings, 1460 lines checked
parent reply other threads:[~2021-04-30 21:39 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210430213747.41530-2-kathleen.capella@arm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210430213946.B00D9121159@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=kathleen.capella@arm.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).