From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id AF4FCA0546
	for <public@inbox.dpdk.org>; Fri, 30 Apr 2021 23:39:49 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 96F1D4014F;
	Fri, 30 Apr 2021 23:39:49 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id A40F84013F
 for <test-report@dpdk.org>; Fri, 30 Apr 2021 23:39:48 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id B00D9121159; Fri, 30 Apr 2021 23:39:46 +0200 (CEST)
In-Reply-To: <20210430213747.41530-2-kathleen.capella@arm.com>
References: <20210430213747.41530-2-kathleen.capella@arm.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Kathleen Capella <kathleen.capella@arm.com>
Message-Id: <20210430213946.B00D9121159@dpdk.org>
Date: Fri, 30 Apr 2021 23:39:46 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw92584 [RFC 1/1] app/testpmd: add
 l3fwd mode to testpmd
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/92584

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#368: FILE: app/test-pmd/l3fwd.c:189:
+	unsigned i;

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#481: FILE: app/test-pmd/l3fwd.c:302:
+	 * TX burst queue drain
+	*/

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#497: FILE: app/test-pmd/l3fwd.c:318:
+       /*
+	 * Receive a burst of packets and forward them.

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#525: FILE: app/test-pmd/l3fwd.c:346:
+	/* TODO check l3fwd_poll_resource_setup to see what must be done on
+		a port level, esp init ports_eth_addr[] */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#525: FILE: app/test-pmd/l3fwd.c:346:
+		a port level, esp init ports_eth_addr[] */

WARNING:TYPO_SPELLING: 'destionation' may be misspelled - perhaps 'destination'?
#744: FILE: app/test-pmd/l3fwd_common.h:54:
+ * We group consecutive packets with the same destionation port into one burst.

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#905: FILE: app/test-pmd/l3fwd_common.h:215:
+	while (j < n) {
+	case 0:

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 16)
#935: FILE: app/test-pmd/l3fwd_common.h:245:
+		while (j < len) {
+		case 0:

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#1003: FILE: app/test-pmd/l3fwd_lpm.h:39:
+	       /* if (dst_port >= RTE_MAX_ETHPORTS ||
+			(enabled_port_mask & 1 << dst_port) == 0)

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#1030: FILE: app/test-pmd/l3fwd_lpm.h:66:
+		/*TODO check if port is enabled
+		if (dst_port >= RTE_MAX_ETHPORTS ||

WARNING:TYPO_SPELLING: 'destionation' may be misspelled - perhaps 'destination'?
#1319: FILE: app/test-pmd/l3fwd_neon.h:67:
+ * Suppose we have array of destionation ports:

total: 0 errors, 11 warnings, 1460 lines checked