automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
Subject: [dpdk-test-report] |WARNING| pw93731 [PATCH v7 03/10] eal/windows: translate Windows errors to errno-style errors
Date: Tue,  1 Jun 2021 22:56:49 +0200 (CEST)	[thread overview]
Message-ID: <20210601205649.449FE120C04@dpdk.org> (raw)
In-Reply-To: <1622580952-25169-4-git-send-email-navasile@linux.microsoft.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93731

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#101: FILE: lib/eal/windows/rte_thread.c:25:
+		return EINVAL;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EFAULT)
#104: FILE: lib/eal/windows/rte_thread.c:28:
+		return EFAULT;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#109: FILE: lib/eal/windows/rte_thread.c:33:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EACCES)
#114: FILE: lib/eal/windows/rte_thread.c:38:
+		return EACCES;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#117: FILE: lib/eal/windows/rte_thread.c:41:
+		return EEXIST;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EDEADLK)
#120: FILE: lib/eal/windows/rte_thread.c:44:
+		return EDEADLK;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOSYS)
#125: FILE: lib/eal/windows/rte_thread.c:49:
+		return ENOSYS;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#128: FILE: lib/eal/windows/rte_thread.c:52:
+	return EINVAL;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#132: FILE: lib/eal/windows/rte_thread.c:56:
+thread_log_last_error(const char* message)

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#154: FILE: lib/eal/windows/rte_thread.c:141:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#178: FILE: lib/eal/windows/rte_thread.c:159:
+		return EINVAL;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#202: FILE: lib/eal/windows/rte_thread.c:178:
+		return EINVAL;

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 2 errors, 11 warnings, 155 lines checked

           reply	other threads:[~2021-06-01 20:56 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1622580952-25169-4-git-send-email-navasile@linux.microsoft.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210601205649.449FE120C04@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=navasile@linux.microsoft.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).