From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
Subject: [dpdk-test-report] |WARNING| pw93916 [PATCH v8 05/10] eal: implement thread priority management functions
Date: Sat, 5 Jun 2021 01:40:18 +0200 (CEST) [thread overview]
Message-ID: <20210604234018.D1756121198@dpdk.org> (raw)
In-Reply-To: <1622849908-5710-6-git-send-email-navasile@linux.microsoft.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93916
_coding style issues_
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#105: FILE: lib/eal/common/rte_thread.c:61:
+ switch (eal_pri)
+ {
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#125: FILE: lib/eal/common/rte_thread.c:81:
+ return EINVAL;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#139: FILE: lib/eal/common/rte_thread.c:95:
+ if (ret != 0) {
+ return ret;
+ }
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#234: FILE: lib/eal/windows/rte_thread.c:230:
+ switch (eal_pri)
+ {
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#246: FILE: lib/eal/windows/rte_thread.c:242:
+ return EINVAL;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#270: FILE: lib/eal/windows/rte_thread.c:266:
+ if (ret != 0) {
+ return ret;
+ }
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 3 errors, 4 warnings, 192 lines checked
parent reply other threads:[~2021-06-04 23:40 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1622849908-5710-6-git-send-email-navasile@linux.microsoft.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210604234018.D1756121198@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=navasile@linux.microsoft.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).