From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A4EA4A0A0F
	for <public@inbox.dpdk.org>; Sat,  5 Jun 2021 01:40:19 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9CBEA4067B;
	Sat,  5 Jun 2021 01:40:19 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id D51EA40147
 for <test-report@dpdk.org>; Sat,  5 Jun 2021 01:40:18 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id D1756121198; Sat,  5 Jun 2021 01:40:18 +0200 (CEST)
In-Reply-To: <1622849908-5710-6-git-send-email-navasile@linux.microsoft.com>
References: <1622849908-5710-6-git-send-email-navasile@linux.microsoft.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
Message-Id: <20210604234018.D1756121198@dpdk.org>
Date: Sat,  5 Jun 2021 01:40:18 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw93916 [PATCH v8 05/10] eal:
 implement thread priority management functions
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93916

_coding style issues_


ERROR:OPEN_BRACE: that open brace { should be on the previous line
#105: FILE: lib/eal/common/rte_thread.c:61:
+	switch (eal_pri)
+	{

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#125: FILE: lib/eal/common/rte_thread.c:81:
+			return EINVAL;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#139: FILE: lib/eal/common/rte_thread.c:95:
+	if (ret != 0) {
+		return ret;
+	}

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#234: FILE: lib/eal/windows/rte_thread.c:230:
+	switch (eal_pri)
+	{

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#246: FILE: lib/eal/windows/rte_thread.c:242:
+			return EINVAL;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#270: FILE: lib/eal/windows/rte_thread.c:266:
+	if (ret != 0) {
+		return ret;
+	}

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 3 errors, 4 warnings, 192 lines checked