automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
Subject: [dpdk-test-report] |WARNING| pw93918 [PATCH v8 06/10] eal: add thread lifetime management
Date: Sat,  5 Jun 2021 01:40:25 +0200 (CEST)	[thread overview]
Message-ID: <20210604234025.A6417121198@dpdk.org> (raw)
In-Reply-To: <1622849908-5710-7-git-send-email-navasile@linux.microsoft.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93918

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#60: 
The *rte_thread_create()* function can optionally receive an rte_thread_attr_t

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#170: FILE: lib/eal/common/rte_thread.c:235:
+	void **pres = NULL;

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#173: FILE: lib/eal/common/rte_thread.c:238:
+		pres = &res;

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#175: FILE: lib/eal/common/rte_thread.c:240:
+	ret = pthread_join(thread_id.opaque_id, pres);

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#181: FILE: lib/eal/common/rte_thread.c:246:
+	if (pres != NULL)

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#182: FILE: lib/eal/common/rte_thread.c:247:
+		*value_ptr = *(int *)(*pres);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#293: FILE: lib/eal/windows/rte_thread.c:18:
+	void* (*start_routine) (void*);

WARNING:SPACING: Unnecessary space before function pointer arguments
#293: FILE: lib/eal/windows/rte_thread.c:18:
+	void* (*start_routine) (void*);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void*' should also have an identifier name
#293: FILE: lib/eal/windows/rte_thread.c:18:
+	void* (*start_routine) (void*);

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#350: FILE: lib/eal/windows/rte_thread.c:400:
+			ret = rte_convert_cpuset_to_affinity(&thread_attr->cpuset, &thread_affinity);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#458: FILE: lib/eal/windows/rte_thread.c:508:
+	return ENOTSUP;

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 2 errors, 10 warnings, 369 lines checked

           reply	other threads:[~2021-06-04 23:40 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1622849908-5710-7-git-send-email-navasile@linux.microsoft.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210604234025.A6417121198@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=navasile@linux.microsoft.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).