[dpdk-test-report] |WARNING| pw93919 [PATCH v8 07/10] eal: implement functions for mutex management

[checkpatch@dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93919

_coding style issues_


ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#206: FILE: lib/eal/windows/include/rte_windows_thread_types.h:10:
+#define WINDOWS_MUTEX_INITIALIZER               (void*)-1

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#206: FILE: lib/eal/windows/include/rte_windows_thread_types.h:10:
+#define WINDOWS_MUTEX_INITIALIZER               (void*)-1

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#210: FILE: lib/eal/windows/include/rte_windows_thread_types.h:14:
+	void* mutex_id;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#251: FILE: lib/eal/windows/rte_thread.c:500:
+	void* id = 0;

WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#257: FILE: lib/eal/windows/rte_thread.c:506:
+	id = InterlockedCompareExchangePointer(&mutex->mutex_id, mutex->mutex_id, WINDOWS_MUTEX_INITIALIZER);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#261: FILE: lib/eal/windows/rte_thread.c:510:
+		if (ret != 0) {
+			return ret;
+		}

WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#265: FILE: lib/eal/windows/rte_thread.c:514:
+		id = InterlockedCompareExchangePointer(&mutex->mutex_id, m.mutex_id, WINDOWS_MUTEX_INITIALIZER);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#269: FILE: lib/eal/windows/rte_thread.c:518:
+		if (id != WINDOWS_MUTEX_INITIALIZER) {
+			rte_thread_mutex_destroy(&m);
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#293: FILE: lib/eal/windows/rte_thread.c:542:
+	if (mutex->mutex_id == WINDOWS_MUTEX_INITIALIZER) {
+		goto cleanup;
+	}

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 5 errors, 5 warnings, 211 lines checked