automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
Subject: [dpdk-test-report] |WARNING| pw93920 [PATCH v8 08/10] eal: implement functions for thread barrier management
Date: Sat,  5 Jun 2021 01:40:30 +0200 (CEST)	[thread overview]
Message-ID: <20210604234030.31C0C121198@dpdk.org> (raw)
In-Reply-To: <1622849908-5710-9-git-send-email-navasile@linux.microsoft.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93920

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#115: FILE: lib/eal/common/rte_thread.c:313:
+	if (ret == PTHREAD_BARRIER_SERIAL_THREAD) {
+		ret = RTE_THREAD_BARRIER_SERIAL_THREAD;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#129: FILE: lib/eal/common/rte_thread.c:327:
+	if (ret != 0) {
+		RTE_LOG(DEBUG, EAL, "Unable to destroy barrier, ret = %d
", ret);
+	}

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#166: FILE: lib/eal/include/rte_thread.h:68:
+	void* barrier_id;  /**< barrrier identifier */

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 2 errors, 2 warnings, 205 lines checked

           reply	other threads:[~2021-06-04 23:40 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1622849908-5710-9-git-send-email-navasile@linux.microsoft.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210604234030.31C0C121198@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=navasile@linux.microsoft.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).