From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E8A05A0A0F
	for <public@inbox.dpdk.org>; Sat,  5 Jun 2021 01:40:31 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E13434067B;
	Sat,  5 Jun 2021 01:40:31 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 35E6C40147
 for <test-report@dpdk.org>; Sat,  5 Jun 2021 01:40:30 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 31C0C121198; Sat,  5 Jun 2021 01:40:30 +0200 (CEST)
In-Reply-To: <1622849908-5710-9-git-send-email-navasile@linux.microsoft.com>
References: <1622849908-5710-9-git-send-email-navasile@linux.microsoft.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
Message-Id: <20210604234030.31C0C121198@dpdk.org>
Date: Sat,  5 Jun 2021 01:40:30 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw93920 [PATCH v8 08/10] eal:
 implement functions for thread barrier management
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93920

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#115: FILE: lib/eal/common/rte_thread.c:313:
+	if (ret == PTHREAD_BARRIER_SERIAL_THREAD) {
+		ret = RTE_THREAD_BARRIER_SERIAL_THREAD;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#129: FILE: lib/eal/common/rte_thread.c:327:
+	if (ret != 0) {
+		RTE_LOG(DEBUG, EAL, "Unable to destroy barrier, ret = %d
", ret);
+	}

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#166: FILE: lib/eal/include/rte_thread.h:68:
+	void* barrier_id;  /**< barrrier identifier */

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 2 errors, 2 warnings, 205 lines checked