From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
Subject: [dpdk-test-report] |WARNING| pw93929 [PATCH v9 07/10] eal: implement functions for mutex management
Date: Sat, 5 Jun 2021 01:45:56 +0200 (CEST) [thread overview]
Message-ID: <20210604234556.235B5121198@dpdk.org> (raw)
In-Reply-To: <1622850274-6946-8-git-send-email-navasile@linux.microsoft.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93929
_coding style issues_
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#208: FILE: lib/eal/windows/include/rte_windows_thread_types.h:10:
+#define WINDOWS_MUTEX_INITIALIZER (void*)-1
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#208: FILE: lib/eal/windows/include/rte_windows_thread_types.h:10:
+#define WINDOWS_MUTEX_INITIALIZER (void*)-1
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#212: FILE: lib/eal/windows/include/rte_windows_thread_types.h:14:
+ void* mutex_id;
ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#253: FILE: lib/eal/windows/rte_thread.c:500:
+ void* id = 0;
WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#259: FILE: lib/eal/windows/rte_thread.c:506:
+ id = InterlockedCompareExchangePointer(&mutex->mutex_id, mutex->mutex_id, WINDOWS_MUTEX_INITIALIZER);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#263: FILE: lib/eal/windows/rte_thread.c:510:
+ if (ret != 0) {
+ return ret;
+ }
WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#267: FILE: lib/eal/windows/rte_thread.c:514:
+ id = InterlockedCompareExchangePointer(&mutex->mutex_id, m.mutex_id, WINDOWS_MUTEX_INITIALIZER);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#271: FILE: lib/eal/windows/rte_thread.c:518:
+ if (id != WINDOWS_MUTEX_INITIALIZER) {
+ rte_thread_mutex_destroy(&m);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#295: FILE: lib/eal/windows/rte_thread.c:542:
+ if (mutex->mutex_id == WINDOWS_MUTEX_INITIALIZER) {
+ goto cleanup;
+ }
total: 4 errors, 5 warnings, 211 lines checked
parent reply other threads:[~2021-06-04 23:45 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1622850274-6946-8-git-send-email-navasile@linux.microsoft.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210604234556.235B5121198@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=navasile@linux.microsoft.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).