From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A679CA0A0F
	for <public@inbox.dpdk.org>; Sat,  5 Jun 2021 01:45:56 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A295840DDC;
	Sat,  5 Jun 2021 01:45:56 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 27A864067B
 for <test-report@dpdk.org>; Sat,  5 Jun 2021 01:45:56 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 235B5121198; Sat,  5 Jun 2021 01:45:56 +0200 (CEST)
In-Reply-To: <1622850274-6946-8-git-send-email-navasile@linux.microsoft.com>
References: <1622850274-6946-8-git-send-email-navasile@linux.microsoft.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
Message-Id: <20210604234556.235B5121198@dpdk.org>
Date: Sat,  5 Jun 2021 01:45:56 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw93929 [PATCH v9 07/10] eal:
 implement functions for mutex management
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93929

_coding style issues_


ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#208: FILE: lib/eal/windows/include/rte_windows_thread_types.h:10:
+#define WINDOWS_MUTEX_INITIALIZER               (void*)-1

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#208: FILE: lib/eal/windows/include/rte_windows_thread_types.h:10:
+#define WINDOWS_MUTEX_INITIALIZER               (void*)-1

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#212: FILE: lib/eal/windows/include/rte_windows_thread_types.h:14:
+	void* mutex_id;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#253: FILE: lib/eal/windows/rte_thread.c:500:
+	void* id = 0;

WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#259: FILE: lib/eal/windows/rte_thread.c:506:
+	id = InterlockedCompareExchangePointer(&mutex->mutex_id, mutex->mutex_id, WINDOWS_MUTEX_INITIALIZER);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#263: FILE: lib/eal/windows/rte_thread.c:510:
+		if (ret != 0) {
+			return ret;
+		}

WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#267: FILE: lib/eal/windows/rte_thread.c:514:
+		id = InterlockedCompareExchangePointer(&mutex->mutex_id, m.mutex_id, WINDOWS_MUTEX_INITIALIZER);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#271: FILE: lib/eal/windows/rte_thread.c:518:
+		if (id != WINDOWS_MUTEX_INITIALIZER) {
+			rte_thread_mutex_destroy(&m);
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#295: FILE: lib/eal/windows/rte_thread.c:542:
+	if (mutex->mutex_id == WINDOWS_MUTEX_INITIALIZER) {
+		goto cleanup;
+	}

total: 4 errors, 5 warnings, 211 lines checked