From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CFA27A0A0F
	for <public@inbox.dpdk.org>; Sat,  5 Jun 2021 01:46:04 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CB7C540DDB;
	Sat,  5 Jun 2021 01:46:04 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 996B94067B
 for <test-report@dpdk.org>; Sat,  5 Jun 2021 01:46:03 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 94D03121198; Sat,  5 Jun 2021 01:46:03 +0200 (CEST)
In-Reply-To: <1622850274-6946-7-git-send-email-navasile@linux.microsoft.com>
References: <1622850274-6946-7-git-send-email-navasile@linux.microsoft.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>
Message-Id: <20210604234603.94D03121198@dpdk.org>
Date: Sat,  5 Jun 2021 01:46:03 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw93932 [PATCH v9 06/10] eal: add
 thread lifetime management
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93932

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#60: 
The *rte_thread_create()* function can optionally receive an rte_thread_attr_t

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#172: FILE: lib/eal/common/rte_thread.c:235:
+	void **pres = NULL;

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#175: FILE: lib/eal/common/rte_thread.c:238:
+		pres = &res;

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#177: FILE: lib/eal/common/rte_thread.c:240:
+	ret = pthread_join(thread_id.opaque_id, pres);

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#183: FILE: lib/eal/common/rte_thread.c:246:
+	if (pres != NULL)

WARNING:TYPO_SPELLING: 'pres' may be misspelled - perhaps 'press'?
#184: FILE: lib/eal/common/rte_thread.c:247:
+		*value_ptr = *(int *)(*pres);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#295: FILE: lib/eal/windows/rte_thread.c:18:
+	void* (*start_routine) (void*);

WARNING:SPACING: Unnecessary space before function pointer arguments
#295: FILE: lib/eal/windows/rte_thread.c:18:
+	void* (*start_routine) (void*);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void*' should also have an identifier name
#295: FILE: lib/eal/windows/rte_thread.c:18:
+	void* (*start_routine) (void*);

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#352: FILE: lib/eal/windows/rte_thread.c:400:
+			ret = rte_convert_cpuset_to_affinity(&thread_attr->cpuset, &thread_affinity);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#460: FILE: lib/eal/windows/rte_thread.c:508:
+	return ENOTSUP;

total: 1 errors, 10 warnings, 369 lines checked