From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Liguzinski, WojciechX" <wojciechx.liguzinski@intel.com>
Subject: [dpdk-test-report] |WARNING| pw94054 [RFC PATCH v1 1/3] sched: add PIE based congestion management
Date: Wed, 9 Jun 2021 12:55:10 +0200 (CEST) [thread overview]
Message-ID: <20210609105510.A8482121198@dpdk.org> (raw)
In-Reply-To: <20210609105337.70405-2-wojciechx.liguzinski@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/94054
_coding style issues_
WARNING:BRACES: braces {} are not necessary for single statement blocks
#177: FILE: lib/sched/rte_pie.c:45:
+ if (pie_cfg == NULL) {
+ return -1;
+ }
WARNING:LONG_LINE_COMMENT: line length of 107 exceeds 100 columns
#241: FILE: lib/sched/rte_pie.h:24:
+#define RTE_DQ_THRESHOLD 16384 /**< Queue length threshold (2^14) to start measurement cycle (bytes) */
WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#265: FILE: lib/sched/rte_pie.h:48:
+ uint64_t dp_update_interval; /**< Update interval for drop probability (in CPU cycles.) */
WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#276: FILE: lib/sched/rte_pie.h:59:
+ uint32_t departed_bytes_count; /**< Number of bytes departed in current measurement cycle */
WARNING:TYPO_SPELLING: 'milliseonds' may be misspelled - perhaps 'milliseconds'?
#306: FILE: lib/sched/rte_pie.h:89:
+ * @param max_burst [in] maximum burst allowance (milliseonds)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#548: FILE: lib/sched/rte_pie.h:331:
+ const unsigned qlen,
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#555: FILE: lib/sched/rte_pie.h:338:
+ if (qlen != 0) {
[...]
+ } else {
[...]
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#571: FILE: lib/sched/rte_pie.h:354:
+rte_pie_dequeue (struct rte_pie *pie,
WARNING:LONG_LINE: line length of 116 exceeds 100 columns
#586: FILE: lib/sched/rte_pie.h:369:
+ pie->avg_dq_time = dq_time * RTE_DQ_WEIGHT + pie->avg_dq_time * (1 - RTE_DQ_WEIGHT);
total: 0 errors, 9 warnings, 935 lines checked
parent reply other threads:[~2021-06-09 10:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210609105337.70405-2-wojciechx.liguzinski@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609105510.A8482121198@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=wojciechx.liguzinski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).