automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw94054 [RFC PATCH v1 1/3] sched: add PIE based congestion management
       [not found] <20210609105337.70405-2-wojciechx.liguzinski@intel.com>
@ 2021-06-09 10:55 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-06-09 10:55 UTC (permalink / raw)
  To: test-report; +Cc: Liguzinski, WojciechX

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/94054

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#177: FILE: lib/sched/rte_pie.c:45:
+	if (pie_cfg == NULL) {
+		return -1;
+	}

WARNING:LONG_LINE_COMMENT: line length of 107 exceeds 100 columns
#241: FILE: lib/sched/rte_pie.h:24:
+#define RTE_DQ_THRESHOLD   16384   /**< Queue length threshold (2^14) to start measurement cycle (bytes) */

WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#265: FILE: lib/sched/rte_pie.h:48:
+	uint64_t dp_update_interval;    /**< Update interval for drop probability (in CPU cycles.) */

WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#276: FILE: lib/sched/rte_pie.h:59:
+	uint32_t departed_bytes_count;  /**< Number of bytes departed in current measurement cycle */

WARNING:TYPO_SPELLING: 'milliseonds' may be misspelled - perhaps 'milliseconds'?
#306: FILE: lib/sched/rte_pie.h:89:
+ * @param max_burst [in] maximum burst allowance (milliseonds)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#548: FILE: lib/sched/rte_pie.h:331:
+	const unsigned qlen,

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#555: FILE: lib/sched/rte_pie.h:338:
+	if (qlen != 0) {
[...]
+	} else {
[...]

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#571: FILE: lib/sched/rte_pie.h:354:
+rte_pie_dequeue (struct rte_pie *pie,

WARNING:LONG_LINE: line length of 116 exceeds 100 columns
#586: FILE: lib/sched/rte_pie.h:369:
+				pie->avg_dq_time = dq_time * RTE_DQ_WEIGHT + pie->avg_dq_time * (1 - RTE_DQ_WEIGHT);

total: 0 errors, 9 warnings, 935 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-06-09 10:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210609105337.70405-2-wojciechx.liguzinski@intel.com>
2021-06-09 10:55 ` [dpdk-test-report] |WARNING| pw94054 [RFC PATCH v1 1/3] sched: add PIE based congestion management checkpatch

automatic DPDK test reports

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/test-report/0 test-report/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 test-report test-report/ https://inbox.dpdk.org/test-report \
		test-report@dpdk.org
	public-inbox-index test-report

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.test-report


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git