From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 74EA3A0C46
	for <public@inbox.dpdk.org>; Wed,  9 Jun 2021 12:55:12 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6E2174069B;
	Wed,  9 Jun 2021 12:55:12 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id BFD794003C
 for <test-report@dpdk.org>; Wed,  9 Jun 2021 12:55:10 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id A8482121198; Wed,  9 Jun 2021 12:55:10 +0200 (CEST)
In-Reply-To: <20210609105337.70405-2-wojciechx.liguzinski@intel.com>
References: <20210609105337.70405-2-wojciechx.liguzinski@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: "Liguzinski, WojciechX" <wojciechx.liguzinski@intel.com>
Message-Id: <20210609105510.A8482121198@dpdk.org>
Date: Wed,  9 Jun 2021 12:55:10 +0200 (CEST)
Subject: [dpdk-test-report] |WARNING| pw94054 [RFC PATCH v1 1/3] sched: add
 PIE based congestion management
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/94054

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#177: FILE: lib/sched/rte_pie.c:45:
+	if (pie_cfg == NULL) {
+		return -1;
+	}

WARNING:LONG_LINE_COMMENT: line length of 107 exceeds 100 columns
#241: FILE: lib/sched/rte_pie.h:24:
+#define RTE_DQ_THRESHOLD   16384   /**< Queue length threshold (2^14) to start measurement cycle (bytes) */

WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#265: FILE: lib/sched/rte_pie.h:48:
+	uint64_t dp_update_interval;    /**< Update interval for drop probability (in CPU cycles.) */

WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#276: FILE: lib/sched/rte_pie.h:59:
+	uint32_t departed_bytes_count;  /**< Number of bytes departed in current measurement cycle */

WARNING:TYPO_SPELLING: 'milliseonds' may be misspelled - perhaps 'milliseconds'?
#306: FILE: lib/sched/rte_pie.h:89:
+ * @param max_burst [in] maximum burst allowance (milliseonds)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#548: FILE: lib/sched/rte_pie.h:331:
+	const unsigned qlen,

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#555: FILE: lib/sched/rte_pie.h:338:
+	if (qlen != 0) {
[...]
+	} else {
[...]

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#571: FILE: lib/sched/rte_pie.h:354:
+rte_pie_dequeue (struct rte_pie *pie,

WARNING:LONG_LINE: line length of 116 exceeds 100 columns
#586: FILE: lib/sched/rte_pie.h:369:
+				pie->avg_dq_time = dq_time * RTE_DQ_WEIGHT + pie->avg_dq_time * (1 - RTE_DQ_WEIGHT);

total: 0 errors, 9 warnings, 935 lines checked