From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2608A0A0C for ; Sat, 19 Jun 2021 13:04:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE8324111A; Sat, 19 Jun 2021 13:04:00 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 0DCBA40E64 for ; Sat, 19 Jun 2021 13:03:59 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 09664122E3A; Sat, 19 Jun 2021 13:03:59 +0200 (CEST) In-Reply-To: <20210619110154.10301-6-pbhagavatula@marvell.com> References: <20210619110154.10301-6-pbhagavatula@marvell.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Message-Id: <20210619110359.09664122E3A@dpdk.org> Date: Sat, 19 Jun 2021 13:03:59 +0200 (CEST) Subject: [dpdk-test-report] |WARNING| pw94546 [PATCH v2 06/13] net/cnxk: add multi seg Tx vector routine X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/94546 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'flags' - possible side-effects? #638: FILE: drivers/net/cnxk/cn10k_tx_vec_mseg.c:8: +#define T(name, f5, f4, f3, f2, f1, f0, sz, flags) \ + uint16_t __rte_noinline __rte_hot cn10k_nix_xmit_pkts_vec_mseg_##name( \ + void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts) \ + { \ + uint64_t cmd[sz]; \ + \ + /* For TSO inner checksum is a must */ \ + if (((flags) & NIX_TX_OFFLOAD_TSO_F) && \ + !((flags) & NIX_TX_OFFLOAD_L3_L4_CSUM_F)) \ + return 0; \ + return cn10k_nix_xmit_pkts_vector( \ + tx_queue, tx_pkts, pkts, cmd, \ + (flags) | NIX_TX_MULTI_SEG_F); \ + } CHECK:MACRO_ARG_REUSE: Macro argument reuse 'flags' - possible side-effects? #1020: FILE: drivers/net/cnxk/cn9k_tx_vec_mseg.c:8: +#define T(name, f5, f4, f3, f2, f1, f0, sz, flags) \ + uint16_t __rte_noinline __rte_hot cn9k_nix_xmit_pkts_vec_mseg_##name( \ + void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts) \ + { \ + uint64_t cmd[sz]; \ + \ + /* For TSO inner checksum is a must */ \ + if (((flags) & NIX_TX_OFFLOAD_TSO_F) && \ + !((flags) & NIX_TX_OFFLOAD_L3_L4_CSUM_F)) \ + return 0; \ + return cn9k_nix_xmit_pkts_vector(tx_queue, tx_pkts, pkts, cmd, \ + (flags) | \ + NIX_TX_MULTI_SEG_F); \ + } total: 0 errors, 0 warnings, 2 checks, 910 lines checked