* [dpdk-test-report] |WARNING| pw94546 [PATCH v2 06/13] net/cnxk: add multi seg Tx vector routine
[not found] <20210619110154.10301-6-pbhagavatula@marvell.com>
@ 2021-06-19 11:03 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2021-06-19 11:03 UTC (permalink / raw)
To: test-report; +Cc: pbhagavatula
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/94546
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'flags' - possible side-effects?
#638: FILE: drivers/net/cnxk/cn10k_tx_vec_mseg.c:8:
+#define T(name, f5, f4, f3, f2, f1, f0, sz, flags) \
+ uint16_t __rte_noinline __rte_hot cn10k_nix_xmit_pkts_vec_mseg_##name( \
+ void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts) \
+ { \
+ uint64_t cmd[sz]; \
+ \
+ /* For TSO inner checksum is a must */ \
+ if (((flags) & NIX_TX_OFFLOAD_TSO_F) && \
+ !((flags) & NIX_TX_OFFLOAD_L3_L4_CSUM_F)) \
+ return 0; \
+ return cn10k_nix_xmit_pkts_vector( \
+ tx_queue, tx_pkts, pkts, cmd, \
+ (flags) | NIX_TX_MULTI_SEG_F); \
+ }
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'flags' - possible side-effects?
#1020: FILE: drivers/net/cnxk/cn9k_tx_vec_mseg.c:8:
+#define T(name, f5, f4, f3, f2, f1, f0, sz, flags) \
+ uint16_t __rte_noinline __rte_hot cn9k_nix_xmit_pkts_vec_mseg_##name( \
+ void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t pkts) \
+ { \
+ uint64_t cmd[sz]; \
+ \
+ /* For TSO inner checksum is a must */ \
+ if (((flags) & NIX_TX_OFFLOAD_TSO_F) && \
+ !((flags) & NIX_TX_OFFLOAD_L3_L4_CSUM_F)) \
+ return 0; \
+ return cn9k_nix_xmit_pkts_vector(tx_queue, tx_pkts, pkts, cmd, \
+ (flags) | \
+ NIX_TX_MULTI_SEG_F); \
+ }
total: 0 errors, 0 warnings, 2 checks, 910 lines checked
^ permalink raw reply [flat|nested] only message in thread