automatic DPDK test reports
 help / color / mirror / Atom feed
From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Subject: [dpdk-test-report] |WARNING| pw94768 [PATCH] net/memif: replace memcpy() with rte_memcpy() to improve perf
Date: Wed, 23 Jun 2021 13:33:23 -0400 (EDT)	[thread overview]
Message-ID: <20210623173323.D1BA288E63@noxus.dpdklab.iol.unh.edu> (raw)

[-- Attachment #1: Type: text/plain, Size: 2025 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/94768

_apply patch failure_

Submitter: David Christensen <drc@linux.vnet.ibm.com>
Date: Wednesday, June 23 2021 16:49:35 
Applied on: CommitID:3a21d59b28c6de3c44fe4a350fbd3589a4349142
Apply patch set 94768 failed:

Checking patch drivers/net/memif/rte_eth_memif.c...
error: while searching for:
				rte_pktmbuf_pkt_len(mbuf_head) += cp_len;

			rte_memcpy(rte_pktmbuf_mtod_offset(mbuf, void *, dst_off),
			       (uint8_t *)memif_get_buffer(proc_private, d0) + src_off,
			       cp_len);

			src_off += cp_len;
			dst_off += cp_len;

error: patch failed: drivers/net/memif/rte_eth_memif.c:384
error: while searching for:
			}
			cp_len = RTE_MIN(dst_len, src_len);

			rte_memcpy((uint8_t *)memif_get_buffer(proc_private, d0) + dst_off,
			       rte_pktmbuf_mtod_offset(mbuf, void *, src_off),
			       cp_len);


error: patch failed: drivers/net/memif/rte_eth_memif.c:644
Applying patch drivers/net/memif/rte_eth_memif.c with 2 rejects...
Rejected hunk #1.
Rejected hunk #2.
diff a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c	(rejected hunks)
@@ -384,8 +384,8 @@ eth_memif_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 				rte_pktmbuf_pkt_len(mbuf_head) += cp_len;
 
 			rte_memcpy(rte_pktmbuf_mtod_offset(mbuf, void *, dst_off),
-			       (uint8_t *)memif_get_buffer(proc_private, d0) + src_off,
-			       cp_len);
+			       (uint8_t *)memif_get_buffer(proc_private, d0)
+			       + src_off, cp_len);
 
 			src_off += cp_len;
 			dst_off += cp_len;
@@ -644,7 +644,8 @@ eth_memif_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
 			}
 			cp_len = RTE_MIN(dst_len, src_len);
 
-			rte_memcpy((uint8_t *)memif_get_buffer(proc_private, d0) + dst_off,
+			rte_memcpy((uint8_t *)
+			       memif_get_buffer(proc_private, d0) + dst_off,
 			       rte_pktmbuf_mtod_offset(mbuf, void *, src_off),
 			       cp_len);
 

https://lab.dpdk.org/results/dashboard/patchsets/17498/

UNH-IOL DPDK Community Lab

                 reply	other threads:[~2021-06-23 17:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210623173323.D1BA288E63@noxus.dpdklab.iol.unh.edu \
    --to=dpdklab@iol.unh.edu \
    --cc=dpdk-test-reports@iol.unh.edu \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).