From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-test-report] |WARNING| pw95430 [RFC UPDATE PATCH 9/9] app/test: add basic dmadev unit test
Date: Tue, 6 Jul 2021 22:31:10 +0200 (CEST) [thread overview]
Message-ID: <20210706203110.B63A41206FD@dpdk.org> (raw)
In-Reply-To: <20210706202841.661302-10-bruce.richardson@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/95430
_coding style issues_
ERROR:INITIALISED_STATIC: do not initialise statics to 0
#106: FILE: app/test/test_dmadev.c:14:
+static uint16_t id_count = 0;
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#177: FILE: app/test/test_dmadev.c:85:
+ if ((j = rte_dmadev_completed(dev_id, 0, RTE_DIM(srcs), NULL,
WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#257: FILE: app/test/test_dmadev.c:165:
+ PRINT_ERR("Error:incorrect job id received, %u [expected %u]
", id, id_count);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#300: FILE: app/test/test_dmadev.c:208:
+ if ((i = rte_dmadev_completed(dev_id, 0, max_ops * 2, &id, NULL)) != max_ops) {
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#305: FILE: app/test/test_dmadev.c:213:
+ PRINT_ERR("Error, incorrect job id returned: got %u not %u
", id, id_count - 1);
WARNING:LONG_LINE_COMMENT: line length of 103 exceeds 100 columns
#320: FILE: app/test/test_dmadev.c:228:
+ || do_multi_copies(dev_id, 1, 0) /* enqueue 2 batches and then complete both */
WARNING:LONG_LINE_COMMENT: line length of 108 exceeds 100 columns
#321: FILE: app/test/test_dmadev.c:229:
+ || do_multi_copies(dev_id, 0, 1); /* enqueue 1 batch, then complete in two halves */
total: 3 errors, 4 warnings, 334 lines checked
parent reply other threads:[~2021-07-06 20:31 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210706202841.661302-10-bruce.richardson@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210706203110.B63A41206FD@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=bruce.richardson@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).