From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2555A0C4D for ; Fri, 20 Aug 2021 18:30:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EADAC4117A; Fri, 20 Aug 2021 18:30:37 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 09CC64121F for ; Fri, 20 Aug 2021 18:30:36 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 0679E1226B3; Fri, 20 Aug 2021 18:30:36 +0200 (CEST) In-Reply-To: <20210820162834.12544-7-konstantin.ananyev@intel.com> References: <20210820162834.12544-7-konstantin.ananyev@intel.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Konstantin Ananyev Message-Id: <20210820163036.0679E1226B3@dpdk.org> Date: Fri, 20 Aug 2021 18:30:36 +0200 (CEST) Subject: [dpdk-test-report] |WARNING| pw97172 [RFC 6/7] eth: make drivers to use new API for Rx queue count X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/97172 _coding style issues_ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #241: FILE: lib/ethdev/ethdev_driver.h:1966: +#define _RTE_ETH_RX_QCNT_DEF(fn) \ +_RTE_ETH_RX_QCNT_PROTO(fn) \ +{ \ + int rc; \ + rc = _rte_eth_rx_qcnt_prolog(port_id, queue_id); \ + if (rc != 0) \ + return rc; \ + return fn(&rte_eth_devices[port_id], queue_id); \ +} WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #241: FILE: lib/ethdev/ethdev_driver.h:1966: +#define _RTE_ETH_RX_QCNT_DEF(fn) \ +_RTE_ETH_RX_QCNT_PROTO(fn) \ +{ \ + int rc; \ + rc = _rte_eth_rx_qcnt_prolog(port_id, queue_id); \ + if (rc != 0) \ + return rc; \ + return fn(&rte_eth_devices[port_id], queue_id); \ +} ERROR:CODE_INDENT: code indent should use tabs where possible #245: FILE: lib/ethdev/ethdev_driver.h:1970: + ^Irc = _rte_eth_rx_qcnt_prolog(port_id, queue_id); \$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #245: FILE: lib/ethdev/ethdev_driver.h:1970: + ^Irc = _rte_eth_rx_qcnt_prolog(port_id, queue_id); \$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #245: FILE: lib/ethdev/ethdev_driver.h:1970: + ^Irc = _rte_eth_rx_qcnt_prolog(port_id, queue_id); \$ total: 2 errors, 3 warnings, 225 lines checked Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c) Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c) Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c)